Switch some ERROR logs to WARNING logs #44784
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
You might consider leaving out the log message altogether, if its not directly actionable.
It's useful information for someone working on the engine. Is there not a reasonable way to log things without it impacting tests? |
|
In that case an INFO or ERROR seems reasonable, and I would probably update the test to ignore this message |
|
Oops, did not mean to close the pull request. |
I would do that but I have no idea how to do that nor is there anything printed in the test failure on how one might go about making an exception for some logs. |
|
Thanks! |
…132717) flutter/engine@dbfe71c...5336702 2023-08-16 [email protected] Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786) 2023-08-16 [email protected] Revert "Conditionally enable HardwareBuffer backed platform views (#44744)" (flutter/engine#44785) 2023-08-16 [email protected] [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782) 2023-08-16 [email protected] Switch some ERROR logs to WARNING logs (flutter/engine#44784) 2023-08-16 [email protected] Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780) 2023-08-16 [email protected] Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770) 2023-08-16 [email protected] Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778) 2023-08-16 [email protected] Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773) 2023-08-16 [email protected] Roll Fuchsia Mac SDK from Zp9or9YwxZHHPeQbA... to VW7WAVPT3Cj5erlae... (flutter/engine#44777) 2023-08-16 [email protected] Fix search web test (flutter/engine#44704) 2023-08-16 [email protected] Roll Fuchsia Linux SDK from GpKKtPGPMiRcY0kcz... to cPncZK6z8HmuOmQr_... (flutter/engine#44769) 2023-08-16 [email protected] Remove duplicated v1 builds. (flutter/engine#44767) 2023-08-16 [email protected] Roll Skia from d029f149a806 to e65aabc26c86 (4 revisions) (flutter/engine#44768) 2023-08-16 [email protected] Split lint.sh into separate scripts for clang-tidy and pylint (flutter/engine#44763) 2023-08-16 [email protected] Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from GpKKtPGPMiRc to cPncZK6z8Hmu fuchsia/sdk/core/mac-amd64 from Zp9or9YwxZHH to VW7WAVPT3Cj5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
No description provided.