This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Make devicePixelRatio ready for multi-view #44783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
force-pushed
the
dpr_multi_view
branch
from
aca38a6 to
e022b25
Compare
mdebbar
force-pushed
the
dpr_multi_view
branch
from
d0650b8 to
6ec5999
Compare
yjbanov
approved these changes
Aug 28, 2023
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2023
…133570) flutter/engine@50bd807...d1e6eb0 2023-08-29 [email protected] Roll Skia from 4048262b9b21 to b0c1b2868129 (2 revisions) (flutter/engine#45227) 2023-08-29 [email protected] [web] Make devicePixelRatio ready for multi-view (flutter/engine#44783) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
This PR moves the source of truth for`devicePixelRatio` to the `EngineFlutterDisplay` singleton. Main things that this PR is trying to do: - `EngineFlutterDisplay` is a singleton that represents information about the display. - The `devicePixelRatio` can be overriden in tests. - The `browserDevicePixelRatio` gets the value directly from the browser and can't be overriden. - Remove `EngineSingletonFlutterWindow` and incorporate it into `EngineFlutterWindow`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the source of truth for
devicePixelRatioto theEngineFlutterDisplaysingleton.Main things that this PR is trying to do:
EngineFlutterDisplayis a singleton that represents information about the display.devicePixelRatiocan be overriden in tests.browserDevicePixelRatiogets the value directly from the browser and can't be overriden.EngineSingletonFlutterWindowand incorporate it intoEngineFlutterWindow.Part of flutter/flutter#134443