This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix FlutterInjectorTest assumptions about how the executor service assigns tasks to threads #44775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signs tasks to threads
Member
|
This seems brittle as there aren't guarantees about the names of threads. But since this is fixing an existing test, lgtm. We should followup to make this stuff less brittle though. |
chinmaygarde
approved these changes
Aug 17, 2023
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 17, 2023
…service assigns tasks to threads (flutter/engine#44775)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2023
…service assigns tasks to threads (flutter/engine#44775)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 18, 2023
…132812) flutter/engine@5019d6d...866b43f 2023-08-17 [email protected] Roll Skia from 1bec2899ace8 to 1e62a2d4c429 (1 revision) (flutter/engine#44829) 2023-08-17 [email protected] Roll Dart SDK from 7e4e5796ee99 to 7101eb7569ac (2 revisions) (flutter/engine#44828) 2023-08-17 [email protected] Roll Skia from e4be2cab442f to 1bec2899ace8 (1 revision) (flutter/engine#44826) 2023-08-17 [email protected] Roll Skia from bfd45173e5e3 to e4be2cab442f (3 revisions) (flutter/engine#44824) 2023-08-17 [email protected] Add Doxygen doc generation for iOS, macOS, Linux, Windows, and Impeller (flutter/engine#43915) 2023-08-17 [email protected] Roll Fuchsia Mac SDK from VW7WAVPT3Cj5erlae... to Tnp43n_nAR2N0l_gY... (flutter/engine#44823) 2023-08-17 [email protected] Fix FlutterInjectorTest assumptions about how the executor service assigns tasks to threads (flutter/engine#44775) 2023-08-17 [email protected] Reenable HardwareBuffer backed Android Platform Views on SDK >= 29 (flutter/engine#44790) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from VW7WAVPT3Cj5 to Tnp43n_nAR2N If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…signs tasks to threads (flutter#44775)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.