Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

This is part of the cleanup of the migration to engine v2 builds.

Bug: flutter/flutter#132600

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is part of the cleanup of the migration to engine v2 builds.

Bug: flutter/flutter#132600
@godofredoc godofredoc requested a review from zanderso August 16, 2023 18:02
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2023
@auto-submit auto-submit bot merged commit 0193ac4 into flutter:main Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 17, 2023
…132717)

flutter/engine@dbfe71c...5336702

2023-08-16 [email protected] Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786)
2023-08-16 [email protected] Revert "Conditionally enable HardwareBuffer backed platform views (#44744)" (flutter/engine#44785)
2023-08-16 [email protected] [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782)
2023-08-16 [email protected] Switch some ERROR logs to WARNING logs (flutter/engine#44784)
2023-08-16 [email protected] Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780)
2023-08-16 [email protected] Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770)
2023-08-16 [email protected] Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778)
2023-08-16 [email protected] Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773)
2023-08-16 [email protected] Roll Fuchsia Mac SDK from Zp9or9YwxZHHPeQbA... to VW7WAVPT3Cj5erlae... (flutter/engine#44777)
2023-08-16 [email protected] Fix search web test (flutter/engine#44704)
2023-08-16 [email protected] Roll Fuchsia Linux SDK from GpKKtPGPMiRcY0kcz... to cPncZK6z8HmuOmQr_... (flutter/engine#44769)
2023-08-16 [email protected] Remove duplicated v1 builds. (flutter/engine#44767)
2023-08-16 [email protected] Roll Skia from d029f149a806 to e65aabc26c86 (4 revisions) (flutter/engine#44768)
2023-08-16 [email protected] Split lint.sh into separate scripts for clang-tidy and pylint (flutter/engine#44763)
2023-08-16 [email protected] Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from GpKKtPGPMiRc to cPncZK6z8Hmu
  fuchsia/sdk/core/mac-amd64 from Zp9or9YwxZHH to VW7WAVPT3Cj5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
@godofredoc godofredoc deleted the remove_v1_builds branch January 12, 2024 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants