Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

These builders have been running as bringup for a very long time with no failures.

Bug: flutter/flutter#132597

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

These builders have been running as bringup for a very long time with no
failures.

Bug: flutter/flutter#132597
@godofredoc godofredoc requested a review from zanderso August 15, 2023 22:27
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2023
@auto-submit auto-submit bot merged commit ed35a3b into flutter:main Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Aug 16, 2023
…132618)

flutter/engine@659cdfc...decaccf

2023-08-16 [email protected] Roll Fuchsia Mac SDK from 7iuIq3PsSkuCmuEMr... to Zp9or9YwxZHHPeQbA... (flutter/engine#44747)
2023-08-16 [email protected] Move cache builders to prod. (flutter/engine#44739)
2023-08-16 [email protected] Enabling the host application to control the timing of attaching the |FlutterView| to the engine (flutter/engine#43595)
2023-08-16 [email protected] Roll Skia from 9fc1c628456a to 3d2b84e28e79 (1 revision) (flutter/engine#44746)
2023-08-16 [email protected] Roll Dart SDK from b36934aae968 to e6bf503b36fe (1 revision) (flutter/engine#44745)
2023-08-16 [email protected] [Skia] Only respect ui.Paint.dither when the colorSource is a gradient (flutter/engine#44730)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 7iuIq3PsSkuC to Zp9or9YwxZHH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@godofredoc godofredoc deleted the move_cache_builders branch August 16, 2023 04:28
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants