This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for SurfaceTexture based external textures on Android under Impeller/GLES. #44734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Aug 15, 2023
| @@ -1,9 +1,10 @@ | |||
|
|
|||
| if (android_context_->RenderingApi() == AndroidRenderingAPI::kOpenGLES) { | ||
| RegisterTexture(std::make_shared<AndroidExternalTextureGL>( | ||
| texture_id, surface_texture, jni_facade_)); | ||
| if (android_context_->GetImpellerContext() != nullptr) { |
Contributor
There was a problem hiding this comment.
I think we'd probably just write it like
Suggested change
| if (android_context_->GetImpellerContext() != nullptr) { | |
| if (android_context_->GetImpellerContext()) { |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…er Impeller/GLES. - Refactor AndroidExternalTextureGL into SurfaceTextureExternalTexture base class. - Add SurfaceTextureExternalTextureGL for legacy GL rendering. - Add SurfaceTextureExternalTextureImpellerGL for Impeller GLES rendering. NOTE: There is still no support for SurfaceTextures under Vulkan rendering.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2023
…ndroid under Impeller/GLES. (flutter/engine#44734)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 16, 2023
…132609) flutter/engine@a9da721...7409ce4 2023-08-16 [email protected] Add more tests for CompositionAwareMixin (flutter/engine#44717) 2023-08-15 [email protected] Fix clang_tidy lints (flutter/engine#44740) 2023-08-15 [email protected] Roll Skia from b07a6964a1cf to 9fc1c628456a (5 revisions) (flutter/engine#44737) 2023-08-15 [email protected] Add SLSA L1 badge (flutter/engine#44731) 2023-08-15 [email protected] Add support for SurfaceTexture based external textures on Android under Impeller/GLES. (flutter/engine#44734) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…er Impeller/GLES. (flutter#44734) - Refactor AndroidExternalTextureGL into SurfaceTextureExternalTexture base class with two specialized implementations: - Add SurfaceTextureExternalTextureGL for legacy GL rendering. - Add SurfaceTextureExternalTextureImpellerGL for Impeller GLES rendering. NOTE: There is still no support for SurfaceTextures under Vulkan rendering.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: There is still no support for SurfaceTextures under Vulkan rendering.