[web] add support for AppLifecycleState changes #44720
Conversation
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
maRci002
force-pushed
the
feat/web-support-app-lifecycle-state-changes
branch
from
5ad3652 to
b8415e3
Compare
cbracken
requested review from
ditman and
yjbanov
and removed request for
cbracken and
chinmaygarde
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
|
Where are we on this? I'd like to land it soon if possible. @maRci002 if you aren't able to, or don't have time to address the remaining issues, please let us know. |
|
Hey @gspencergoog, I was able to resolve the earlier timeout issue. However, I've now come across a new challenge while working with the I'm not sure how to best handle this in |
I don't think that expectation is needed anyhow. I'm going to remove it, see this PR: flutter/flutter#141822 |
## Description This removes an unneeded expectation in the test for the AppLifecycleListener. It's unneeded because the test immediately resets the state anyhow. I'm removing it because the web implementation sets the value when initializing, so it's never initially null there. ## Related PR - flutter/engine#44720 (comment)
Thanks for the fast pull request; now every check passes. |
gspencergoog
added
the
autosubmit
…142245) flutter/engine@3b47793...55eefd5 2024-01-25 [email protected] Roll Skia from bcc2e8b6105a to de46a989e0ca (1 revision) (flutter/engine#50046) 2024-01-25 [email protected] [Impeller] turned on vulkan validation for all but one golden test (flutter/engine#50045) 2024-01-25 [email protected] Roll Skia from 56c06ee7a252 to bcc2e8b6105a (2 revisions) (flutter/engine#50042) 2024-01-25 [email protected] [Impeller] call shutdown method in Android context. (flutter/engine#49992) 2024-01-25 [email protected] [web] add support for AppLifecycleState changes (flutter/engine#44720) 2024-01-25 [email protected] Roll Skia from 416d7b0e5ba1 to 56c06ee7a252 (1 revision) (flutter/engine#50040) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
5 participants
closes flutter/flutter#53107
This PR introduces support for
AppLifecycleStateon Web, aligning the web's lifecycle events with those of the mobile platforms. This ensures a more consistent developer experience and better lifecycle management across all platforms.PR includes:
visibilitychangeDOM event to determine if the app is in aresumedorpausedstate based on the visibility state of the document.beforeunloadevents to better manage thedetachedstate.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.