This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add more tests for CompositionAwareMixin #44717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@htoor3 @Renzo-Olivares Could you please take a look at this one too? |
Renzo-Olivares
approved these changes
Aug 15, 2023
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
Thank you for the contribution @Amir-P! LGTM with some small formatting nits. Thank you for improving the test coverage.
Contributor
Author
|
Done. @Renzo-Olivares |
Renzo-Olivares
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 16, 2023
…132609) flutter/engine@a9da721...7409ce4 2023-08-16 [email protected] Add more tests for CompositionAwareMixin (flutter/engine#44717) 2023-08-15 [email protected] Fix clang_tidy lints (flutter/engine#44740) 2023-08-15 [email protected] Roll Skia from b07a6964a1cf to 9fc1c628456a (5 revisions) (flutter/engine#44737) 2023-08-15 [email protected] Add SLSA L1 badge (flutter/engine#44731) 2023-08-15 [email protected] Add support for SurfaceTexture based external textures on Android under Impeller/GLES. (flutter/engine#44734) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Adds missing tests for `CompositionAwareMixin`. Check flutter#44139 (comment) and flutter#44139 (comment) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing tests for
CompositionAwareMixin. Check #44139 (comment) and #44139 (comment)Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.