This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix search web test #44704
Merged
Fix search web test #44704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shell/platform/darwin/ios/framework/Source/FlutterPlatformPluginTest.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/ios/framework/Source/FlutterPlatformPluginTest.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/ios/framework/Source/FlutterPlatformPluginTest.mm
Outdated
Show resolved
Hide resolved
| @end | ||
|
|
||
| @implementation FlutterPlatformPluginTest | ||
| - (void)testSearchWebInvoked { |
Contributor
There was a problem hiding this comment.
Can you split the test into testSearchWebInvokedWith[Escaped / NonEscaped]SearchTerm tests?
…o fix-search-web-test
hellohuanlin
approved these changes
Aug 16, 2023
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 17, 2023
…132717) flutter/engine@dbfe71c...5336702 2023-08-16 [email protected] Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786) 2023-08-16 [email protected] Revert "Conditionally enable HardwareBuffer backed platform views (#44744)" (flutter/engine#44785) 2023-08-16 [email protected] [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782) 2023-08-16 [email protected] Switch some ERROR logs to WARNING logs (flutter/engine#44784) 2023-08-16 [email protected] Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780) 2023-08-16 [email protected] Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770) 2023-08-16 [email protected] Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778) 2023-08-16 [email protected] Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773) 2023-08-16 [email protected] Roll Fuchsia Mac SDK from Zp9or9YwxZHHPeQbA... to VW7WAVPT3Cj5erlae... (flutter/engine#44777) 2023-08-16 [email protected] Fix search web test (flutter/engine#44704) 2023-08-16 [email protected] Roll Fuchsia Linux SDK from GpKKtPGPMiRcY0kcz... to cPncZK6z8HmuOmQr_... (flutter/engine#44769) 2023-08-16 [email protected] Remove duplicated v1 builds. (flutter/engine#44767) 2023-08-16 [email protected] Roll Skia from d029f149a806 to e65aabc26c86 (4 revisions) (flutter/engine#44768) 2023-08-16 [email protected] Split lint.sh into separate scripts for clang-tidy and pylint (flutter/engine#44763) 2023-08-16 [email protected] Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from GpKKtPGPMiRc to cPncZK6z8Hmu fuchsia/sdk/core/mac-amd64 from Zp9or9YwxZHH to VW7WAVPT3Cj5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Fixed an issue with the test `testSearchWebInvoked` not mocking out openURL and crashing subsequent tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with the test
testSearchWebInvokednot mocking out openURL and crashing subsequent testsPre-launch Checklist
///).