This repository was archived by the owner on Feb 25, 2025. It is now read-only.
allow ParagraphBuilder.shouldDisableRoundingHack to actually be set to false in tests
#44647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
force-pushed
the
fix-shouldDisableRoundingHack
branch
from
e9fe080 to
a97f531
Compare
LongCatIsLooong
force-pushed
the
fix-shouldDisableRoundingHack
branch
from
a97f531 to
93dd9b2
Compare
chingjun
approved these changes
Aug 11, 2023
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2023
…lly be set to false in tests (flutter/engine#44647)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 12, 2023
…132427) flutter/engine@e59ea16...f6ad8d5 2023-08-12 [email protected] Roll Dart SDK from ade04f1beb2c to e23931233ff2 (1 revision) (flutter/engine#44657) 2023-08-12 [email protected] Remove dependencies on fuchsia.sys.* FIDL protocols (flutter/engine#44614) 2023-08-12 [email protected] Roll Skia from dc71a424d870 to e0f07834d736 (1 revision) (flutter/engine#44655) 2023-08-11 [email protected] allow `ParagraphBuilder.shouldDisableRoundingHack` to actually be set to false in tests (flutter/engine#44647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
… to false in tests (flutter#44647) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.