This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update android_embedding_bundle CIPD instructions #44644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
force-pushed
the
android-deps-license
branch
3 times, most recently
from
7e2fd03 to
5dd469b
Compare
reidbaker
approved these changes
Aug 14, 2023
| 3. Run `./generate.sh`. | ||
| 1. Update `tools/androidx/files.json`. (This file includes the Maven | ||
| dependencies used to build Flutter apps). | ||
| 1. `cd` into this directory. |
Contributor
There was a problem hiding this comment.
Can you spell out the directory? It is nice when following instructions that have not been run in a while to be super specific.
Suggested change
| 1. `cd` into this directory. | |
| 1. `cd` into `tools/androidx` directory. |
Contributor
|
This implementation matches my understanding of the advice we were given. I'll let @reidbaker give the actual approval since he has a better understanding of the subtleties of the relevant code. |
zanderso
force-pushed
the
android-deps-license
branch
from
5dd469b to
44e6519
Compare
reidbaker
approved these changes
Aug 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 14, 2023
…132534) flutter/engine@3c88528...1d63eec 2023-08-14 [email protected] Update android_embedding_bundle CIPD instructions (flutter/engine#44644) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
This PR updates the gradle build file for the android_embedding_bundle cipd package to fetch license information about the dependencies listed under `tools/androidx/files.json`. The README file for the android_embedding_bundle now explains how to fetch the license information and make sure it's correct in the cipd package. This PR also pulls a new version of android_embedding_dependencies that includes a `LICENSE` file. It turns out that Flutter does not re-ship anything from the embedding bundle to Flutter end-users. These dependencies are only used to create a classpath against which we build the Android embedder and in-tree tests. I've updated docs/comments to clarify that since I was initially confused about how these were used. I'm not adding a test that compares the license info fetched from maven against a checked-in golden, yet. Still thinking about the most effective way to do that in combination with the steps in the README.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the gradle build file for the android_embedding_bundle cipd package to fetch license information about the dependencies listed under
tools/androidx/files.json. The README file for the android_embedding_bundle now explains how to fetch the license information and make sure it's correct in the cipd package.This PR also pulls a new version of android_embedding_dependencies that includes a
LICENSEfile.It turns out that Flutter does not re-ship anything from the embedding bundle to Flutter end-users. These dependencies are only used to create a classpath against which we build the Android embedder and in-tree tests. I've updated docs/comments to clarify that since I was initially confused about how these were used.
I'm not adding a test that compares the license info fetched from maven against a checked-in golden, yet. Still thinking about the most effective way to do that in combination with the steps in the README.