This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Android a11y bridge sets importantness" #44589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9117ff2.
Contributor
|
https://developer.android.com/reference/android/view/View#setImportantForAccessibility(int) This shows that the method was available starting at api 16. Can you link whatever you found that made you think we needed 24 and above? |
Contributor
Author
The link you posted is for |
reidbaker
approved these changes
Aug 10, 2023
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 10, 2023
…132332) flutter/engine@a9be77e...16b01b9 2023-08-10 [email protected] Roll Dart SDK from 46da53e7abe2 to a2eac00da6b8 (1 revision) (flutter/engine#44601) 2023-08-10 [email protected] Fix unexpected pointer change issue and Add test case (flutter/engine#43949) 2023-08-10 [email protected] Reland "Android a11y bridge sets importantness" (flutter/engine#44589) 2023-08-10 [email protected] Support for Android Platform Views under Impeller/Vulkan (flutter/engine#44571) 2023-08-10 [email protected] Reintroduce Windows lifecycle with guard for posthumous `OnWindowStateEvent` (flutter/engine#44344) 2023-08-10 [email protected] Roll Skia from 92e6f52b0fa8 to b6492f5ce8c3 (1 revision) (flutter/engine#44597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
The previous pr was reverted due to test failures. The failure was due to API not supported in order android version. The fix is in the second commit. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pr was reverted due to test failures. The failure was due to API not supported in order android version. The fix is in the second commit.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.