This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Flutter iOS Interactive Keyboard: Fixing Behavior Issue #44586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
approved these changes
Aug 10, 2023
| [self showKeyboardAndRemoveScreenshot]; | ||
| if (_keyboardView.superview != nil) { | ||
| // Done to avoid the issue of a pointer up done without a screenshot | ||
| // View must be loaded at this point. |
| CGFloat keyboardHeight = _keyboardRect.size.height; | ||
| // Negative velocity indicates a downward movement | ||
| BOOL shouldDismissKeyboardBasedOnVelocity = _pointerYVelocity < 0; | ||
| [UIView animateWithDuration:0.3f |
Contributor
There was a problem hiding this comment.
can you make it a constant at the top of file?
Contributor
Author
There was a problem hiding this comment.
Definitely, added a description as well.
| } else { | ||
| [self setKeyboardContainerHeight:pointerY]; | ||
| _pointerYVelocity = _previousPointerYPosition - pointerY; | ||
| NSLog(@"%f", _pointerYVelocity); |
Contributor
Author
There was a problem hiding this comment.
Slipped by me. Will remove right away!
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 10, 2023
…132328) flutter/engine@ea7730c...a9be77e 2023-08-10 [email protected] Flutter iOS Interactive Keyboard: Fixing Behavior Issue (flutter/engine#44586) 2023-08-10 [email protected] [Impeller] Flutter GPU: Add context override. (flutter/engine#44566) 2023-08-10 [email protected] [Impeller] External OpenGLES texture sampling. (flutter/engine#44559) 2023-08-10 [email protected] Roll Fuchsia Linux SDK from 961_tJawsbLMdy5i0... to konJQZKk2qXc276iA... (flutter/engine#44593) 2023-08-10 [email protected] Roll Skia from 364900538771 to 92e6f52b0fa8 (1 revision) (flutter/engine#44592) 2023-08-10 [email protected] Roll Skia from f39fd2de8f10 to 364900538771 (1 revision) (flutter/engine#44590) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 961_tJawsbLM to konJQZKk2qXc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
This PR addresses an issue with the behavior of the keyboard. Originally the behavior of the keyboard was to see if the pointer was above or below the middle of the keyboards full size and then animate appropriately. However we found that the behavior is instead based on velocity. This PR adjust the code to match this behavior. Design Document: https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1 Issues Address: flutter/flutter#57609 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the behavior of the keyboard. Originally the behavior of the keyboard was to see if the pointer was above or below the middle of the keyboards full size and then animate appropriately. However we found that the behavior is instead based on velocity. This PR adjust the code to match this behavior.
Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1
Issues Address:
flutter/flutter#57609
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.