[Impeller] External OpenGLES texture sampling. #44559
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
impeller/compiler/types.h
Outdated
| namespace impeller { | ||
| namespace compiler { | ||
|
|
||
| const std::string kExternalTexturePrefix = "SAMPLER_EXTERNAL_"; |
There was a problem hiding this comment.
nit:
- This should be constexpr
- We call it SAMPLER_EXTERNAL_ here but in TextureType it is ExternalOES -- would be nice if they shared the same name "SAMPLER_EXTERNAL_OES"
- Does this constant belong in types.h It's not a type, maybe it should be format.h right near the definition of TextureType::kTextureExternalOES so folks reading the code know these two concepts are tightly coupled.
There was a problem hiding this comment.
- Switched to constexpr char*.
- Done.
- Moved it to a new
constants.h; I don't think the compiler depends onimpeller/coreright now.
There was a problem hiding this comment.
(Although we could probably pull some of the format stuff from core into base at some point)
bdero
force-pushed
the
bdero/impellerc-external-textures
branch
4 times, most recently
from
8cd9906 to
12d5ac0
Compare
|
auto label is removed for flutter/engine/44559, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
bdero
force-pushed
the
bdero/impellerc-external-textures
branch
from
59d33ec to
1e9d758
Compare
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/44559, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bdero
force-pushed
the
bdero/impellerc-external-textures
branch
from
1e9d758 to
9ab0a74
Compare
…132328) flutter/engine@ea7730c...a9be77e 2023-08-10 [email protected] Flutter iOS Interactive Keyboard: Fixing Behavior Issue (flutter/engine#44586) 2023-08-10 [email protected] [Impeller] Flutter GPU: Add context override. (flutter/engine#44566) 2023-08-10 [email protected] [Impeller] External OpenGLES texture sampling. (flutter/engine#44559) 2023-08-10 [email protected] Roll Fuchsia Linux SDK from 961_tJawsbLMdy5i0... to konJQZKk2qXc276iA... (flutter/engine#44593) 2023-08-10 [email protected] Roll Skia from 364900538771 to 92e6f52b0fa8 (1 revision) (flutter/engine#44592) 2023-08-10 [email protected] Roll Skia from f39fd2de8f10 to 364900538771 (1 revision) (flutter/engine#44590) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 961_tJawsbLM to konJQZKk2qXc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Allows for sampling from external textures in the OpenGLES backend. DrawImageRect should Just Work if external textures are wrapped with the new `kTextureExternalOES` type.
2 participants
Allows for sampling from external textures in the OpenGLES backend. DrawImageRect should Just Work if external textures are wrapped with the new
kTextureExternalOEStype.