This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Flutter iOS Interactive Keyboard: Fixing Animation Issue #44514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
Aug 8, 2023
| [self dismissKeyboardScreenshot]; | ||
| // UIKit does not immediately access the areAnimationsEnabled Boolean so a delay is needed before | ||
| // returned | ||
| dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 0.1 * NSEC_PER_SEC), dispatch_get_main_queue(), ^{ |
Member
There was a problem hiding this comment.
We should extract a constant and use that here:
// Detailed explanation of why this is necessary.
constexpr int64_t kKeyboardAnimationDelayNs = 0.1 * NSEC_PER_SEC;
// Alternatively a detailed explanation here and...
static const NSTimeInterval kKeyboardAnimationDelaySeconds = 0.1;
// ... then use (int64_t)kKeyboardAnimationDelaySeconds * NSEC_PER_SEC in the dispatch_time call.
Contributor
Author
There was a problem hiding this comment.
Definitely! Just added.
Logharaa
reviewed
Aug 9, 2023
| static constexpr double kUITextInputAccessibilityEnablingDelaySeconds = 0.5; | ||
|
|
||
| // A delay before reenabling the UIView areAnimationsEnabled to YES | ||
| // in order for becomeFirstResponder to recieve the proper value |
There was a problem hiding this comment.
Suggested change
| // in order for becomeFirstResponder to recieve the proper value | |
| // in order for becomeFirstResponder to receive the proper value |
Contributor
Author
There was a problem hiding this comment.
Thank you! Those will slip by me from time to time.
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
zanderso
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 10, 2023
…132284) flutter/engine@b5b41ff...9117ff2 2023-08-10 [email protected] Revert "Android a11y bridge sets importantness" (flutter/engine#44569) 2023-08-10 [email protected] Roll Skia from 491f67637e6e to 7c5f6b17a998 (2 revisions) (flutter/engine#44568) 2023-08-10 [email protected] [Impeller] Replace Vulkan rotation checks with polling (flutter/engine#44361) 2023-08-10 [email protected] Disable text rounding hack by default (flutter/engine#44544) 2023-08-09 [email protected] Roll Skia from 3d5a6138b7e5 to 491f67637e6e (4 revisions) (flutter/engine#44563) 2023-08-09 [email protected] Manual roll Dart SDK from f664f4b9c50d to d89e4ead966d (11 revisions) (flutter/engine#44560) 2023-08-09 [email protected] Make toJS'd function use JS types (flutter/engine#44469) 2023-08-09 [email protected] [web] Fix rendering of gradients in html mode (flutter/engine#40345) 2023-08-09 [email protected] Flutter iOS Interactive Keyboard: Fixing Animation Issue (flutter/engine#44514) 2023-08-09 [email protected] Roll Skia from 8c9a8d3e073c to 3d5a6138b7e5 (4 revisions) (flutter/engine#44557) 2023-08-09 [email protected] Roll Skia from d210bab77137 to 8c9a8d3e073c (1 revision) (flutter/engine#44555) 2023-08-09 [email protected] Roll Skia from 25aedb939915 to d210bab77137 (2 revisions) (flutter/engine#44550) 2023-08-09 [email protected] Roll Fuchsia Mac SDK from e7bMhkfY-RPMrSMhB... to zoCGnScKZWbm5s9Hy... (flutter/engine#44548) 2023-08-09 [email protected] Roll Skia from 17ba2122707b to 25aedb939915 (3 revisions) (flutter/engine#44547) 2023-08-09 [email protected] Android a11y bridge sets importantness (flutter/engine#44452) 2023-08-09 [email protected] Roll Fuchsia Linux SDK from tO6r8iQqnmsYkLcvZ... to ZCP8LDbKF4LTBFz_W... (flutter/engine#44545) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from tO6r8iQqnmsY to ZCP8LDbKF4LT fuchsia/sdk/core/mac-amd64 from e7bMhkfY-RPM to zoCGnScKZWbm If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cbracken
reviewed
Aug 10, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
woohoo - sorry; meant to hit lgtm on my last review but posted as a comment instead. LGTM!
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
This PR addresses an issue with the animation of the keyboard. In iOS 16.0 a delay was included in UIView becomeFirstResponder where the areAnimationsEnabled boolean is no longer immediately read. In response to this issue a delay is added that allows for the animation to be properly disabled. Design Document: https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1 Issues Address: flutter/flutter#57609 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the animation of the keyboard. In iOS 16.0 a delay was included in UIView becomeFirstResponder where the areAnimationsEnabled boolean is no longer immediately read. In response to this issue a delay is added that allows for the animation to be properly disabled.
Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1
Issues Address:
flutter/flutter#57609
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.