This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Disable HTML renderer paragraph input width flooring #44478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
force-pushed
the
disable-html-renderer-paragraph-input-width-rounding
branch
from
3c00aa9 to
08c88c4
Compare
LongCatIsLooong
commented
Aug 8, 2023
| addTearDown(() => ParagraphBuilder.setDisableRoundingHack(false)); | ||
| } | ||
| assert(ParagraphBuilder.shouldDisableRoundingHack); | ||
| const double fontSize = 1; |
Contributor
Author
There was a problem hiding this comment.
I noticed that the fontSize is floored in the css (
LongCatIsLooong
added
the
autosubmit
LongCatIsLooong
deleted the
disable-html-renderer-paragraph-input-width-rounding
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 8, 2023
…132166) flutter/engine@934ebb0...82292b8 2023-08-08 [email protected] Roll Skia from 9fa8ebdfdbb8 to 68b80f663be6 (1 revision) (flutter/engine#44511) 2023-08-08 [email protected] Disable HTML renderer paragraph input width flooring (flutter/engine#44478) 2023-08-08 [email protected] Roll Skia from 5c8c7faf9131 to 9fa8ebdfdbb8 (2 revisions) (flutter/engine#44507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
14 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Hopefully the flooring will no longer be needed once the framework stops doing the rounding. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully the flooring will no longer be needed once the framework stops doing the rounding.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.