This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Flutter iOS Interactive Keyboard: Handle Pointer Up #44457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt2D
changed the title
hellohuanlin
reviewed
Aug 7, 2023
| } | ||
|
|
||
| - (void)hideKeyboardWithoutAnimation { | ||
| - (void)hideKeyboardWithoutAnimationAndCursorNotDismissed:{ |
Contributor
There was a problem hiding this comment.
nit: ...AndAvoidCursorDismissUpdate
hellohuanlin
reviewed
Aug 7, 2023
| @property(nonatomic, readonly) CATransform3D editableTransform; | ||
| @property(nonatomic, assign) CGRect markedRect; | ||
| // Disables the cursor from dismissing when firstResponder is resigned | ||
| @property(nonatomic, assign) BOOL resignFirstResponderCallTempDisabled; |
Contributor
There was a problem hiding this comment.
Nit: preventCursorDismissWhenResignFirstResponder
hellohuanlin
approved these changes
Aug 7, 2023
Contributor
hellohuanlin
left a comment
hellohuanlin
left a comment
There was a problem hiding this comment.
Looks very clean. Just some nits
cbracken
reviewed
Aug 8, 2023
| UIScreen* screen = _viewController.flutterScreenIfViewLoaded; | ||
| CGFloat screenHeight = screen.bounds.size.height; | ||
| CGFloat keyboardHeight = _keyboardRect.size.height; | ||
| BOOL pointerBelowMiddleY = (screenHeight - (keyboardHeight / 2)) < pointerY; |
Member
There was a problem hiding this comment.
I would name this shouldDismissKeyboard or shouldHideKeyboard or similar. Ideally describe the intent of the variable rather than how it's computed (which is already on the right-hand side here).
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 8, 2023
…132159) flutter/engine@dd03fae...934ebb0 2023-08-08 [email protected] Roll Skia from 6fa6fdd04783 to 5c8c7faf9131 (3 revisions) (flutter/engine#44506) 2023-08-08 [email protected] Flutter iOS Interactive Keyboard: Handle Pointer Up (flutter/engine#44457) 2023-08-08 [email protected] [Impeller] improved glyph hashing performance (flutter/engine#44502) 2023-08-08 [email protected] Roll Skia from 30c0319e7e42 to 6fa6fdd04783 (2 revisions) (flutter/engine#44503) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
14 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
This PR address the movement aspect of the flutter interactive keyboard. It handles pointer up while a scroll view widget is visible, and the interactive behavior is chosen for keyboardDismissBehavior. This is a desired behavior of the keyboard that has not yet been implemented. Design Document: https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1 Issues Address: flutter/flutter#57609 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the movement aspect of the flutter interactive keyboard. It handles pointer up while a scroll view widget is visible, and the interactive behavior is chosen for keyboardDismissBehavior. This is a desired behavior of the keyboard that has not yet been implemented.
Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1
Issues Address:
flutter/flutter#57609
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.