-
Notifications
You must be signed in to change notification settings - Fork 6k
Check for a detached FlutterNativeView before sending messages #4445
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I think this might trade the crash with potentially missing data... |
|
Ideally plugins would have better connections to the lifecycle of the FlutterView and activity. But for now this will restore the behavior FlutterView used prior to the FlutterNativeView refactoring. |
|
This specific issue is probably fixed after 619f452 since the BinaryMessenger handed to the plugin is the FlutterNativeView rather than the FlutterView. See: 619f452#diff-0fee8a5b0006794b358771128c92c9c8R96 However, adding these checks is probably harmless. |
Fixes flutter/flutter#13481