Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member Author

zanderso commented Aug 7, 2023

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 7, 2023

auto label is removed for flutter/engine/44442, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2023
@zanderso zanderso merged commit 4c6714b into main Aug 7, 2023
@zanderso zanderso deleted the zanderso-patch-5 branch August 7, 2023 18:30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Aug 8, 2023
…132108)

flutter/engine@c271092...9c83d90

2023-08-07 [email protected] Roll Dart SDK from 0816d590a220 to f664f4b9c50d (1 revision) (flutter/engine#44462)
2023-08-07 [email protected] [Impeller] Flutter GPU: Add GpuContext. (flutter/engine#44359)
2023-08-07 [email protected] Fix use-after-free crash in glfw embedder (flutter/engine#44358)
2023-08-07 [email protected] Roll Skia from 9fbd7296de9a to d1ada6624536 (1 revision) (flutter/engine#44447)
2023-08-07 [email protected] Revert clang back to 6d667d4b261e81f325756fdfd5bb43b3b3d2451d (flutter/engine#44442)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 15, 2023
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants