Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add parameters to SemanticActions; implement extend selection for a11y #4444

Merged
goderbauer merged 7 commits into from
Dec 12, 2017
Merged

Add parameters to SemanticActions; implement extend selection for a11y #4444

goderbauer merged 7 commits into from
Dec 12, 2017

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 11, 2017 •
edited
Loading

Framework change in flutter/flutter#13490.

Required for flutter/flutter#13391.

@goderbauer goderbauer mentioned this pull request Dec 11, 2017
Merged
jason-simmons
jason-simmons reviewed Dec 11, 2017
View reviewed changes
shell/common/platform_view.cc Outdated
if (engine) {
engine->DispatchSemanticsAction(
id, static_cast<blink::SemanticsAction>(action));
id, static_cast<blink::SemanticsAction>(action), args);
Copy link
Member

@jason-simmons jason-simmons Dec 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass std::move(args) here (and in Engine and RuntimeController)

@goderbauer goderbauer merged commit 59c3a37 into flutter:master Dec 12, 2017
@goderbauer goderbauer deleted the selection branch December 12, 2017 18:06
@zanderso
Copy link
Member

zanderso commented Dec 12, 2017

It looks like this commit causes a failure when running Flutter gallery:

E/flutter ( 3611): type '(int, SemanticsAction) => void' is not a subtype of type 'SemanticsActionCallback' of 'callback'
E/flutter ( 3611): #0      Window.onSemanticsAction= (file:///usr/local/google/home/zra/flutter/engine/src/flutter/lib/ui/window.dart:601)
E/flutter ( 3611): #1      BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&RendererBinding.initInstances (package:flutter/src/rendering/binding.dart:41)
E/flutter ( 3611): #2      BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&RendererBinding&WidgetsBinding.initInstances (package:flutter/src/widgets/binding.dart:241)
E/flutter ( 3611): #3      new BindingBase (package:flutter/src/foundation/binding.dart:51)
E/flutter ( 3611): #4      new BindingBase&GestureBinding (package:flutter/src/gestures/binding.dart:19)
E/flutter ( 3611): #5      new BindingBase&GestureBinding&ServicesBinding (package:flutter/src/services/binding.dart:19)
E/flutter ( 3611): #6      new BindingBase&GestureBinding&ServicesBinding&SchedulerBinding (package:flutter/src/scheduler/binding.dart:168)
E/flutter ( 3611): #7      new BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding (package:flutter/src/painting/binding.dart:15)
E/flutter ( 3611): #8      new BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&RendererBinding (package:flutter/src/rendering/binding.dart:23)
E/flutter ( 3611): #9      new BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&RendererBinding&WidgetsBinding (package:flutter/src/widgets/binding.dart:234)
E/flutter ( 3611): #10     new WidgetsFlutterBinding (package:flutter/src/widgets/binding.dart:878)
E/flutter ( 3611): #11     WidgetsFlutterBinding.ensureInitialized (package:flutter/src/widgets/binding.dart:893)
E/flutter ( 3611): #12     runApp (package:flutter/src/widgets/binding.dart:688)
E/flutter ( 3611): #13     main (file:///usr/local/google/home/zra/flutter/flutter/examples/flutter_gallery/lib/main.dart:13)
E/flutter ( 3611): #14     _startIsolate.<anonymous closure> (dart:isolate-patch/dart:isolate/isolate_patch.dart:277)
E/flutter ( 3611): #15     _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:163)

@goderbauer
Copy link
Member Author

goderbauer commented Dec 12, 2017

@zanderso You will need this framework-side change: flutter/flutter#13490

It's ready to commit once the bots have build the new engine version with this change.

@goderbauer
Copy link
Member Author

goderbauer commented Dec 12, 2017

Looks like the bots are failing to build the engine with this change. Rolling this back for now until I know what's going on.

goderbauer added a commit that referenced this pull request Dec 12, 2017
@goderbauer
Revert " Add parameters to SemanticActions; implement extend selectio…
442aa47 
…n for a11y (#4444)"

This reverts commit 59c3a37.
@goderbauer goderbauer mentioned this pull request Dec 12, 2017
Merged
goderbauer added a commit that referenced this pull request Dec 12, 2017
@goderbauer
Revert " Add parameters to SemanticActions; implement extend selectio…
056fd45 
…n for a11y (#4444)" (#4448)

This reverts commit 59c3a37.
cbracken added a commit to cbracken/flutter that referenced this pull request Dec 12, 2017
@cbracken
Roll engine to 6c6b709
0dacb74 
Includes:
flutter/engine#4442
flutter/engine#4445
flutter/engine#4444
flutter/engine#4448 (reverts flutter/engine#4444)
flutter/engine#4447
@cbracken cbracken mentioned this pull request Dec 12, 2017
Merged
cbracken added a commit to flutter/flutter that referenced this pull request Dec 12, 2017
@cbracken
Roll engine to 6c6b709 (#13522)
63027b0 
Includes:
flutter/engine#4442
flutter/engine#4445
flutter/engine#4444
flutter/engine#4448 (reverts flutter/engine#4444)
flutter/engine#4447
goderbauer added a commit to goderbauer/engine that referenced this pull request Dec 12, 2017
@goderbauer
Revert "Revert " Add parameters to SemanticActions; implement extend …
acf0c64 
…selection for a11y (flutter#4444)" (flutter#4448)"

This reverts commit 056fd45.
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@cbracken
Roll engine to 6c6b709 (flutter#13522)
6825b5e 
Includes:
flutter/engine#4442
flutter/engine#4445
flutter/engine#4444
flutter/engine#4448 (reverts flutter/engine#4444)
flutter/engine#4447
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accessibility cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@goderbauer @zanderso @jason-simmons @googlebot