This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Darwin] Enable ARC in darwin/common unit tests #44396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Aug 4, 2023
shell/platform/darwin/common/framework/Source/flutter_standard_codec_unittest.mm
Show resolved
Hide resolved
8 tasks
The end goal is for all Objective-C code to be compiled with ARC enabled. The common framework code is already compiled with ARC enabled; this enables it for the tests as well. Issue: flutter/flutter#116445
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2023
…131955) flutter/engine@c254deb...4f4734c 2023-08-04 [email protected] [Darwin] Enable ARC in darwin/common unit tests (flutter/engine#44396) 2023-08-04 [email protected] Roll Skia from 45c0a830d805 to 6dc76e862f90 (2 revisions) (flutter/engine#44399) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
The end goal is for all Objective-C code to be compiled with ARC enabled. The common framework code is already compiled with ARC enabled; this enables it for the tests as well. This is prework before migrating FlutterBinaryMessengerRelay to the common Darwin code. Issue: flutter/flutter#116445 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end goal is for all Objective-C code to be compiled with ARC enabled. The common framework code is already compiled with ARC enabled; this enables it for the tests as well.
This is prework before migrating FlutterBinaryMessengerRelay to the common Darwin code.
Issue: flutter/flutter#116445
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.