Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Aug 3, 2023

Remove commented out debug code from expectSemanticsTree.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Aug 3, 2023
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 3, 2023

auto label is removed for flutter/engine, pr: 44350, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2023
@auto-submit auto-submit bot merged commit c271092 into flutter:main Aug 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 8, 2023
…132086)

flutter/engine@be085f6...c271092

2023-08-07 [email protected] [web] remove leftover comments from
semantics tester (flutter/engine#44350)
2023-08-07 [email protected] Roll Skia from 77007f51bf81 to
9fbd7296de9a (4 revisions) (flutter/engine#44443)
2023-08-07 [email protected] Roll Skia from f19578685d17 to
77007f51bf81 (1 revision) (flutter/engine#44440)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 15, 2023
14 tasks
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
Remove commented out debug code from `expectSemanticsTree`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants