This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add @Keep annotations to avoid dead code elimination of classes only referenced by JNI #44337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…referenced via JNI
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
approved these changes
Aug 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2023
…sses only referenced by JNI (flutter/engine#44337)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 3, 2023
…ions) (#131880) Manual roll requested by [email protected] flutter/engine@4cc0b3d...b08e141 2023-08-03 [email protected] Add @keep annotations to avoid dead code elimination of classes only referenced by JNI (flutter/engine#44337) 2023-08-03 [email protected] Roll Skia from bd3ee535e246 to 36072a994f11 (2 revisions) (flutter/engine#44329) 2023-08-03 [email protected] Roll Dart SDK from dcd09f5726b7 to e3d2b4a190aa (1 revision) (flutter/engine#44330) 2023-08-03 [email protected] [Impeller] updated validation layers documentation (flutter/engine#44328) 2023-08-03 [email protected] [ios]make the screenIfViewLoaded and windowSceneIfLoaded helpers reusable (flutter/engine#44303) 2023-08-03 [email protected] Roll Skia from 768050436c0a to bd3ee535e246 (2 revisions) (flutter/engine#44327) 2023-08-03 [email protected] Re-Re-Land Support for rendering Android Platform Views into a HardwareBuffer backed texture (flutter/engine#44326) 2023-08-03 [email protected] Roll Skia from 8a377a9545b8 to 768050436c0a (1 revision) (flutter/engine#44320) 2023-08-03 [email protected] [Flutter GPU] Export symbols from engine, stub for testing on CI. (flutter/engine#44280) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…referenced by JNI (flutter#44337) Missing piece
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing piece