Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gaaclarke
Copy link
Member

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chinmaygarde
Copy link
Member

Fixes flutter/flutter#131718

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2023
@auto-submit auto-submit bot merged commit 9025bfb into flutter:main Aug 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 3, 2023
…ions) (#131880)

Manual roll requested by [email protected]

flutter/engine@4cc0b3d...b08e141

2023-08-03 [email protected] Add @keep annotations to avoid dead code elimination of classes only referenced by JNI (flutter/engine#44337)
2023-08-03 [email protected] Roll Skia from bd3ee535e246 to 36072a994f11 (2 revisions) (flutter/engine#44329)
2023-08-03 [email protected] Roll Dart SDK from dcd09f5726b7 to e3d2b4a190aa (1 revision) (flutter/engine#44330)
2023-08-03 [email protected] [Impeller] updated validation layers documentation (flutter/engine#44328)
2023-08-03 [email protected] [ios]make the screenIfViewLoaded and windowSceneIfLoaded helpers reusable (flutter/engine#44303)
2023-08-03 [email protected] Roll Skia from 768050436c0a to bd3ee535e246 (2 revisions) (flutter/engine#44327)
2023-08-03 [email protected] Re-Re-Land Support for rendering Android Platform Views into a HardwareBuffer backed texture (flutter/engine#44326)
2023-08-03 [email protected] Roll Skia from 8a377a9545b8 to 768050436c0a (1 revision) (flutter/engine#44320)
2023-08-03 [email protected] [Flutter GPU] Export symbols from engine, stub for testing on CI. (flutter/engine#44280)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

[Impeller] Documentation to manually enable Vulkan validation on Android is outdated.

2 participants