This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[ios]make the screenIfViewLoaded and windowSceneIfLoaded helpers reusable #44303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
mossmana
suggested changes
Aug 2, 2023
Contributor
mossmana
left a comment
mossmana
left a comment
There was a problem hiding this comment.
Thanks for doing this work. It was something I considered initially, but wanted to wait and see if there would be other cases where a shared utility could be used.
shell/platform/darwin/ios/framework/Source/UIViewController+FlutterScreenAndSceneIfLoaded.mm
Show resolved
Hide resolved
shell/platform/darwin/ios/framework/Source/UIViewController+FlutterScreenAndSceneIfLoaded.mm
Show resolved
Hide resolved
Contributor
Author
@mossmana Yep, I would do the same - previously we only needed them inside Looks like there are some issues with license files update. Will fix them tomorrow. |
hellohuanlin
force-pushed
the
reusable_screen_scene_if_loaded_helper
branch
from
79e8723 to
b2ab55c
Compare
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 3, 2023
…ions) (#131880) Manual roll requested by [email protected] flutter/engine@4cc0b3d...b08e141 2023-08-03 [email protected] Add @keep annotations to avoid dead code elimination of classes only referenced by JNI (flutter/engine#44337) 2023-08-03 [email protected] Roll Skia from bd3ee535e246 to 36072a994f11 (2 revisions) (flutter/engine#44329) 2023-08-03 [email protected] Roll Dart SDK from dcd09f5726b7 to e3d2b4a190aa (1 revision) (flutter/engine#44330) 2023-08-03 [email protected] [Impeller] updated validation layers documentation (flutter/engine#44328) 2023-08-03 [email protected] [ios]make the screenIfViewLoaded and windowSceneIfLoaded helpers reusable (flutter/engine#44303) 2023-08-03 [email protected] Roll Skia from 768050436c0a to bd3ee535e246 (2 revisions) (flutter/engine#44327) 2023-08-03 [email protected] Re-Re-Land Support for rendering Android Platform Views into a HardwareBuffer backed texture (flutter/engine#44326) 2023-08-03 [email protected] Roll Skia from 8a377a9545b8 to 768050436c0a (1 revision) (flutter/engine#44320) 2023-08-03 [email protected] [Flutter GPU] Export symbols from engine, stub for testing on CI. (flutter/engine#44280) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…able (flutter#44303) The existing `screenIfViewLoaded` and `windowSceneIfLoaded` functions are private helpers of `FlutterViewController` class. This PR moves the logic to a category of the `UIViewController`, so it can be reused for any `UIViewController`s. *List which issues are fixed by this PR. You must list at least one issue.* flutter#43972 (comment) *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
screenIfViewLoadedandwindowSceneIfLoadedfunctions are private helpers ofFlutterViewControllerclass. This PR moves the logic to a category of theUIViewController, so it can be reused for anyUIViewControllers.List which issues are fixed by this PR. You must list at least one issue.
#43972 (comment)
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.