Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Member

Saying this fixes the two linked issue pushes the bounds of credulity. But this is the best information we have ATM on how to fix the obscure "Invalid UUID" error. And, I have linked to the PR thread as a breadcrumb. Not sure how to do better 🤷🏽‍♂️.

Fixes flutter/flutter#120326
Fixes flutter/flutter#121430

…rce debugging.

Fixes flutter/flutter#120326
Fixes flutter/flutter#121430

Saying this fixes the two linked issue pushes the bounds of credulity.
But this is the best information we have ATM on how to fix the obscure
"Invalid UUID" error. And, I have linked to the issue thread as a
breadcrumb. Not sure how to do better.
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2023
@auto-submit auto-submit bot merged commit 89be3bf into flutter:main Aug 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 1, 2023
…131645)

flutter/engine@bb2a903...791f505

2023-08-01 [email protected] Roll Skia from 2e5f08012a92 to 177897b13a89 (1 revision) (flutter/engine#44199)
2023-08-01 [email protected] Roll ANGLE from cb4b1f3641ae to 6dc0c9d62755 (2 revisions) (flutter/engine#44198)
2023-08-01 [email protected] [Impeller] Document the fiddly bits about setting up Metal shader source debugging. (flutter/engine#44195)
2023-07-31 [email protected] [Impeller] Add documentation on how to enable Metal Profiling HUD without Xcode. (flutter/engine#44196)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
…lutter#131645)

flutter/engine@bb2a903...791f505

2023-08-01 [email protected] Roll Skia from 2e5f08012a92 to 177897b13a89 (1 revision) (flutter/engine#44199)
2023-08-01 [email protected] Roll ANGLE from cb4b1f3641ae to 6dc0c9d62755 (2 revisions) (flutter/engine#44198)
2023-08-01 [email protected] [Impeller] Document the fiddly bits about setting up Metal shader source debugging. (flutter/engine#44195)
2023-07-31 [email protected] [Impeller] Add documentation on how to enable Metal Profiling HUD without Xcode. (flutter/engine#44196)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
…rce debugging. (flutter#44195)

Saying this fixes the two linked issue pushes the bounds of credulity. But this is the best information we have ATM on how to fix the obscure "Invalid UUID" error. And, I have linked to the PR thread as a breadcrumb. Not sure how to do better �����.

Fixes flutter/flutter#120326
Fixes flutter/flutter#121430
@chinmaygarde chinmaygarde deleted the invaliduud branch August 22, 2024 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

[Impeller] Document how to debug generated Metal shaders. [impeller] Shader source debugging is hard to setup in Xcode frame debugger.

3 participants