This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Document the fiddly bits about setting up Metal shader source debugging. #44195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce debugging. Fixes flutter/flutter#120326 Fixes flutter/flutter#121430 Saying this fixes the two linked issue pushes the bounds of credulity. But this is the best information we have ATM on how to fix the obscure "Invalid UUID" error. And, I have linked to the issue thread as a breadcrumb. Not sure how to do better.
jonahwilliams
approved these changes
Jul 31, 2023
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matanlurey
reviewed
Jul 31, 2023
matanlurey
approved these changes
Jul 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2023
…shader source debugging. (flutter/engine#44195)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2023
…shader source debugging. (flutter/engine#44195)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2023
…131645) flutter/engine@bb2a903...791f505 2023-08-01 [email protected] Roll Skia from 2e5f08012a92 to 177897b13a89 (1 revision) (flutter/engine#44199) 2023-08-01 [email protected] Roll ANGLE from cb4b1f3641ae to 6dc0c9d62755 (2 revisions) (flutter/engine#44198) 2023-08-01 [email protected] [Impeller] Document the fiddly bits about setting up Metal shader source debugging. (flutter/engine#44195) 2023-07-31 [email protected] [Impeller] Add documentation on how to enable Metal Profiling HUD without Xcode. (flutter/engine#44196) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131645) flutter/engine@bb2a903...791f505 2023-08-01 [email protected] Roll Skia from 2e5f08012a92 to 177897b13a89 (1 revision) (flutter/engine#44199) 2023-08-01 [email protected] Roll ANGLE from cb4b1f3641ae to 6dc0c9d62755 (2 revisions) (flutter/engine#44198) 2023-08-01 [email protected] [Impeller] Document the fiddly bits about setting up Metal shader source debugging. (flutter/engine#44195) 2023-07-31 [email protected] [Impeller] Add documentation on how to enable Metal Profiling HUD without Xcode. (flutter/engine#44196) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…rce debugging. (flutter#44195) Saying this fixes the two linked issue pushes the bounds of credulity. But this is the best information we have ATM on how to fix the obscure "Invalid UUID" error. And, I have linked to the PR thread as a breadcrumb. Not sure how to do better ð�¤·ð��½â��â��ï¸�. Fixes flutter/flutter#120326 Fixes flutter/flutter#121430
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saying this fixes the two linked issue pushes the bounds of credulity. But this is the best information we have ATM on how to fix the obscure "Invalid UUID" error. And, I have linked to the PR thread as a breadcrumb. Not sure how to do better 🤷🏽♂️.
Fixes flutter/flutter#120326
Fixes flutter/flutter#121430