Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Member

@chinmaygarde chinmaygarde requested a review from bdero July 31, 2023 21:10
@chinmaygarde chinmaygarde self-assigned this Jul 31, 2023
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2023
@auto-submit auto-submit bot merged commit 82748c2 into flutter:main Jul 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 31, 2023
…131638)

flutter/engine@b83172a...fe23695

2023-07-31 [email protected] Roll ANGLE from faca95f7e81b to 196713767078 (7 revisions) (flutter/engine#44191)
2023-07-31 [email protected] Mention the point of BlendMode.plus and advise on using it. (flutter/engine#44189)
2023-07-31 [email protected] Roll Skia from db813f4043fe to 2e5f08012a92 (1 revision) (flutter/engine#44187)
2023-07-31 [email protected] [Impeller] Update guidance on how to try Impeller on macOS Desktop. (flutter/engine#44186)
2023-07-31 [email protected] [Impeller] Add a descriptive blurb about newer Impeller components and fix links. (flutter/engine#44183)
2023-07-31 [email protected] Roll Skia from 06174bc8f4d5 to db813f4043fe (1 revision) (flutter/engine#44182)
2023-07-31 [email protected] [Impeller] Create a wrapper Impeller context for each Vulkan surface and its swapchain (flutter/engine#44171)
2023-07-31 [email protected] Roll Skia from ea0c9c0935ae to 06174bc8f4d5 (2 revisions) (flutter/engine#44179)
2023-07-31 [email protected] Roll ANGLE from 2755f73a3461 to faca95f7e81b (1 revision) (flutter/engine#44178)
2023-07-31 [email protected] Roll Skia from 9c12eb0e158a to ea0c9c0935ae (4 revisions) (flutter/engine#44177)
2023-07-31 [email protected] Roll Skia from 685e29df6704 to 9c12eb0e158a (2 revisions) (flutter/engine#44173)
2023-07-31 [email protected] Roll Skia from cb61dd4af8a5 to 685e29df6704 (2 revisions) (flutter/engine#44170)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
…lutter#131638)

flutter/engine@b83172a...fe23695

2023-07-31 [email protected] Roll ANGLE from faca95f7e81b to 196713767078 (7 revisions) (flutter/engine#44191)
2023-07-31 [email protected] Mention the point of BlendMode.plus and advise on using it. (flutter/engine#44189)
2023-07-31 [email protected] Roll Skia from db813f4043fe to 2e5f08012a92 (1 revision) (flutter/engine#44187)
2023-07-31 [email protected] [Impeller] Update guidance on how to try Impeller on macOS Desktop. (flutter/engine#44186)
2023-07-31 [email protected] [Impeller] Add a descriptive blurb about newer Impeller components and fix links. (flutter/engine#44183)
2023-07-31 [email protected] Roll Skia from 06174bc8f4d5 to db813f4043fe (1 revision) (flutter/engine#44182)
2023-07-31 [email protected] [Impeller] Create a wrapper Impeller context for each Vulkan surface and its swapchain (flutter/engine#44171)
2023-07-31 [email protected] Roll Skia from ea0c9c0935ae to 06174bc8f4d5 (2 revisions) (flutter/engine#44179)
2023-07-31 [email protected] Roll ANGLE from 2755f73a3461 to faca95f7e81b (1 revision) (flutter/engine#44178)
2023-07-31 [email protected] Roll Skia from 9c12eb0e158a to ea0c9c0935ae (4 revisions) (flutter/engine#44177)
2023-07-31 [email protected] Roll Skia from 685e29df6704 to 9c12eb0e158a (2 revisions) (flutter/engine#44173)
2023-07-31 [email protected] Roll Skia from cb61dd4af8a5 to 685e29df6704 (2 revisions) (flutter/engine#44170)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@chinmaygarde chinmaygarde deleted the addmac branch August 22, 2024 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants