Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Ignore the NOTICE.fuchsia file in the new license script #44021

Merged
auto-submit merged 1 commit into from
Jul 27, 2023
Merged

Ignore the NOTICE.fuchsia file in the new license script #44021

auto-submit merged 1 commit into from
Jul 27, 2023

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Jul 25, 2023

See #34038

@jason-simmons jason-simmons requested a review from Hixie July 25, 2023 22:00
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 25, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jason-simmons jason-simmons force-pushed the license_notice_fuchsia branch from 802abd6 to 301f717 Compare July 26, 2023 15:36
Hixie
Hixie approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

My understanding is that the licenses in this file are a mix of licenses that we pick up ourselves in our own detailed scan of the SDK files, and licenses that don't apply to us because we don't use the code covered by those licenses, and that that is why it's ok to ignore this file.

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2023
@auto-submit auto-submit bot merged commit 7b83dbe into flutter:main Jul 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
c5b0ab9 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
63950d2 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
a0f2b97 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
d0725a2 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
5a9f884 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
e256e9f 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
e1330ef 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
4df34d4 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
81263a4 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
46f0ad3 
…lutter/engine#44021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
7b83dbe7c Ignore the NOTICE.fuchsia file in the new license script (f…
306afd9 
…lutter/engine#44021)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 27, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (#…
7e7a0a8 
…131426)

flutter/engine@9b14c38...08050cd

2023-07-27 [email protected] Roll Skia from 90048a938eb5 to 26ec2772960b (2 revisions) (flutter/engine#44070)
2023-07-27 [email protected] Roll ANGLE from 8aa3ca9d177c to d5ddb710e5bd (1 revision) (flutter/engine#44069)
2023-07-27 [email protected] [Impeller] trimmed 3 bytes off of each Glyph (flutter/engine#44054)
2023-07-27 [email protected] Roll Skia from 6571d88db5b3 to 90048a938eb5 (1 revision) (flutter/engine#44066)
2023-07-27 [email protected] Roll ANGLE from af5bf5b8245e to 8aa3ca9d177c (1 revision) (flutter/engine#44065)
2023-07-27 [email protected] Roll Dart SDK from b6747a06be06 to dcbaffbd09dd (1 revision) (flutter/engine#44064)
2023-07-27 [email protected] Roll Fuchsia Mac SDK from pgJmG2-qZVMzlMuq8... to EpwAiaHKf6M6Yejtk... (flutter/engine#44063)
2023-07-27 [email protected] Roll Skia from 26ed0d2ab04c to 6571d88db5b3 (1 revision) (flutter/engine#44062)
2023-07-27 [email protected] Roll Skia from e85c64d63787 to 26ed0d2ab04c (3 revisions) (flutter/engine#44061)
2023-07-27 [email protected] Roll Fuchsia Linux SDK from DOxjABQZ-mA_9Lllw... to FwIA6BaHtZg2mRS-0... (flutter/engine#44060)
2023-07-27 [email protected] Ignore the NOTICE.fuchsia file in the new license script (flutter/engine#44021)
2023-07-27 [email protected] Embed a license readme in every zip archive (flutter/engine#43974)
2023-07-27 [email protected] Roll Skia from 750d7f8ed4d7 to e85c64d63787 (4 revisions) (flutter/engine#44056)
2023-07-27 [email protected] Roll Dart SDK from 8961d36eaa0c to b6747a06be06 (1 revision) (flutter/engine#44053)
2023-07-26 [email protected] Roll ANGLE from 451b3c31a1fa to af5bf5b8245e (1 revision) (flutter/engine#44050)
2023-07-26 [email protected] Roll Skia from fdf224be4f98 to 750d7f8ed4d7 (3 revisions) (flutter/engine#44049)
2023-07-26 [email protected] Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048)
2023-07-26 [email protected] Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046)
2023-07-26 [email protected] Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045)
2023-07-26 [email protected] Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044)
2023-07-26 [email protected] Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043)
2023-07-26 [email protected] Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from DOxjABQZ-mA_ to FwIA6BaHtZg2
  fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to EpwAiaHKf6M6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (f…
68379bf 
…lutter#131426)

flutter/engine@9b14c38...08050cd

2023-07-27 [email protected] Roll Skia from 90048a938eb5 to 26ec2772960b (2 revisions) (flutter/engine#44070)
2023-07-27 [email protected] Roll ANGLE from 8aa3ca9d177c to d5ddb710e5bd (1 revision) (flutter/engine#44069)
2023-07-27 [email protected] [Impeller] trimmed 3 bytes off of each Glyph (flutter/engine#44054)
2023-07-27 [email protected] Roll Skia from 6571d88db5b3 to 90048a938eb5 (1 revision) (flutter/engine#44066)
2023-07-27 [email protected] Roll ANGLE from af5bf5b8245e to 8aa3ca9d177c (1 revision) (flutter/engine#44065)
2023-07-27 [email protected] Roll Dart SDK from b6747a06be06 to dcbaffbd09dd (1 revision) (flutter/engine#44064)
2023-07-27 [email protected] Roll Fuchsia Mac SDK from pgJmG2-qZVMzlMuq8... to EpwAiaHKf6M6Yejtk... (flutter/engine#44063)
2023-07-27 [email protected] Roll Skia from 26ed0d2ab04c to 6571d88db5b3 (1 revision) (flutter/engine#44062)
2023-07-27 [email protected] Roll Skia from e85c64d63787 to 26ed0d2ab04c (3 revisions) (flutter/engine#44061)
2023-07-27 [email protected] Roll Fuchsia Linux SDK from DOxjABQZ-mA_9Lllw... to FwIA6BaHtZg2mRS-0... (flutter/engine#44060)
2023-07-27 [email protected] Ignore the NOTICE.fuchsia file in the new license script (flutter/engine#44021)
2023-07-27 [email protected] Embed a license readme in every zip archive (flutter/engine#43974)
2023-07-27 [email protected] Roll Skia from 750d7f8ed4d7 to e85c64d63787 (4 revisions) (flutter/engine#44056)
2023-07-27 [email protected] Roll Dart SDK from 8961d36eaa0c to b6747a06be06 (1 revision) (flutter/engine#44053)
2023-07-26 [email protected] Roll ANGLE from 451b3c31a1fa to af5bf5b8245e (1 revision) (flutter/engine#44050)
2023-07-26 [email protected] Roll Skia from fdf224be4f98 to 750d7f8ed4d7 (3 revisions) (flutter/engine#44049)
2023-07-26 [email protected] Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048)
2023-07-26 [email protected] Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046)
2023-07-26 [email protected] Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045)
2023-07-26 [email protected] Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044)
2023-07-26 [email protected] Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043)
2023-07-26 [email protected] Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from DOxjABQZ-mA_ to FwIA6BaHtZg2
  fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to EpwAiaHKf6M6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll @vashworth
Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (f…
fa6abce 
…lutter#131426)

flutter/engine@9b14c38...08050cd

2023-07-27 [email protected] Roll Skia from 90048a938eb5 to 26ec2772960b (2 revisions) (flutter/engine#44070)
2023-07-27 [email protected] Roll ANGLE from 8aa3ca9d177c to d5ddb710e5bd (1 revision) (flutter/engine#44069)
2023-07-27 [email protected] [Impeller] trimmed 3 bytes off of each Glyph (flutter/engine#44054)
2023-07-27 [email protected] Roll Skia from 6571d88db5b3 to 90048a938eb5 (1 revision) (flutter/engine#44066)
2023-07-27 [email protected] Roll ANGLE from af5bf5b8245e to 8aa3ca9d177c (1 revision) (flutter/engine#44065)
2023-07-27 [email protected] Roll Dart SDK from b6747a06be06 to dcbaffbd09dd (1 revision) (flutter/engine#44064)
2023-07-27 [email protected] Roll Fuchsia Mac SDK from pgJmG2-qZVMzlMuq8... to EpwAiaHKf6M6Yejtk... (flutter/engine#44063)
2023-07-27 [email protected] Roll Skia from 26ed0d2ab04c to 6571d88db5b3 (1 revision) (flutter/engine#44062)
2023-07-27 [email protected] Roll Skia from e85c64d63787 to 26ed0d2ab04c (3 revisions) (flutter/engine#44061)
2023-07-27 [email protected] Roll Fuchsia Linux SDK from DOxjABQZ-mA_9Lllw... to FwIA6BaHtZg2mRS-0... (flutter/engine#44060)
2023-07-27 [email protected] Ignore the NOTICE.fuchsia file in the new license script (flutter/engine#44021)
2023-07-27 [email protected] Embed a license readme in every zip archive (flutter/engine#43974)
2023-07-27 [email protected] Roll Skia from 750d7f8ed4d7 to e85c64d63787 (4 revisions) (flutter/engine#44056)
2023-07-27 [email protected] Roll Dart SDK from 8961d36eaa0c to b6747a06be06 (1 revision) (flutter/engine#44053)
2023-07-26 [email protected] Roll ANGLE from 451b3c31a1fa to af5bf5b8245e (1 revision) (flutter/engine#44050)
2023-07-26 [email protected] Roll Skia from fdf224be4f98 to 750d7f8ed4d7 (3 revisions) (flutter/engine#44049)
2023-07-26 [email protected] Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048)
2023-07-26 [email protected] Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046)
2023-07-26 [email protected] Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045)
2023-07-26 [email protected] Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044)
2023-07-26 [email protected] Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043)
2023-07-26 [email protected] Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from DOxjABQZ-mA_ to FwIA6BaHtZg2
  fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to EpwAiaHKf6M6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
@jason-simmons @gaaclarke
Ignore the NOTICE.fuchsia file in the new license script (flutter#44021)
373aa3e 
See flutter#34038
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Hixie Hixie Hixie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-simmons @Hixie