This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add Expanded/Collapsed state for SubmenuButton
#43983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-android
platform-web
QuncCccccc
force-pushed
the
add_expanded_collaped_state
branch
from
183de0d to
6f6069b
Compare
QuncCccccc
changed the title
SubmenuButtonSubmenuButton
QuncCccccc
requested review from
cbracken and
chunhtai
and removed request for
cbracken and
chinmaygarde
Contributor
Author
|
I will create a PR in flutter/flutter to disable the failed framework tests temporarily. |
QuncCccccc
force-pushed
the
add_expanded_collaped_state
branch
from
c171358 to
2b3b0dc
Compare
This was referenced Jul 26, 2023
Merged
chunhtai
reviewed
Jul 27, 2023
Contributor
Author
Oh I think there's already an update in this file:) Is that what you want? |
Contributor
yes, you are right! for some reason I missed it. |
chunhtai
approved these changes
Jul 27, 2023
lib/ui/semantics.dart
Outdated
|
|
||
| /// The semantics node has the quality of either being "expanded" or "collapsed". | ||
| /// | ||
| /// For example, a submenu button widget has expanded state. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// For example, a submenu button widget has expanded state. | |
| /// For example, a [SubmenuButton] widget has expanded state. |
Contributor
There was a problem hiding this comment.
not entirely sure if the doc string can pick this up.
Contributor
Author
There was a problem hiding this comment.
Just checked other api doc and looks like using square bracket can link to the widget doc. Thanks for the suggestion:)
QuncCccccc
added a commit
to flutter/flutter
that referenced
this pull request
Jul 27, 2023
…on (#131359) This PR is to skip some unit tests in order to merging an [engine change](flutter/engine#43983).
QuncCccccc
force-pushed
the
add_expanded_collaped_state
branch
from
2b3b0dc to
05d9a01
Compare
QuncCccccc
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 43983, due to - The status or check suite Linux linux_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
QuncCccccc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 28, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 28, 2023
…131453) flutter/engine@0713d91...b0d97ba 2023-07-28 [email protected] Add Expanded/Collapsed state for `SubmenuButton` (flutter/engine#43983) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…on (flutter#131359) This PR is to skip some unit tests in order to merging an [engine change](flutter/engine#43983).
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#131453) flutter/engine@0713d91...b0d97ba 2023-07-28 [email protected] Add Expanded/Collapsed state for `SubmenuButton` (flutter/engine#43983) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…on (flutter#131359) This PR is to skip some unit tests in order to merging an [engine change](flutter/engine#43983).
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131453) flutter/engine@0713d91...b0d97ba 2023-07-28 [email protected] Add Expanded/Collapsed state for `SubmenuButton` (flutter/engine#43983) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
This PR is to add support for the expanded/collapsed-state semantics flag to the engine. After adding another PR to Flutter, we will be able to support the expanded/collapsed state in semantics for submenu buttons. Related to [#127617](flutter/flutter#127617) in flutter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add support for the expanded/collapsed-state semantics flag to the engine. After adding another PR to Flutter, we will be able to support the expanded/collapsed state in semantics for submenu buttons.
Related to #127617 in flutter
Pre-launch Checklist
///).