This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Embed a license readme in every zip archive #43974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Jul 24, 2023
Hixie
reviewed
Jul 24, 2023
build/zip_bundle.gni
Outdated
| "This bundle is part of the the Flutter SDK.", | ||
| "", | ||
| "The source code is hosted at [flutter/engine/$source_path]($git_url/$source_path).", | ||
| "The for this bundle is hosted at [flutter/engine/sky/packages/sky_engine/LICENSE]($git_url/$license_path).", |
Contributor
There was a problem hiding this comment.
is there any way we can make this URL point to a file on the same host as the zip files are hosted?
My concern is that the lifetime of github.com and the lifetime of the host where we upload the zip files is not guaranteed to be correlated, so if we suddenly find github goes away and we have to move all the code, all these old files will no longer point to a license file.
Contributor
Author
There was a problem hiding this comment.
We'd have to modify the recipes to do that, but we could. @godofredoc WDYT?
Contributor
Author
There was a problem hiding this comment.
Actually, I think we can now control it from the build json.. I'll look into that tomorrow.
Contributor
Author
There was a problem hiding this comment.
Ok, I've added a link to the sky_engine.zip location as well, which should have a full copy of the license.
Co-authored-by: Zachary Anderson <[email protected]>
Member
|
Looks like a couple of unrelated diffs got included in the PR. |
Contributor
Author
I was wondering where those files went... removed. |
Contributor
|
LGTM but I'm not qualified to review the build file changes, I just don't have recent-enough experience with that. |
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 27, 2023
…131426) flutter/engine@9b14c38...08050cd 2023-07-27 [email protected] Roll Skia from 90048a938eb5 to 26ec2772960b (2 revisions) (flutter/engine#44070) 2023-07-27 [email protected] Roll ANGLE from 8aa3ca9d177c to d5ddb710e5bd (1 revision) (flutter/engine#44069) 2023-07-27 [email protected] [Impeller] trimmed 3 bytes off of each Glyph (flutter/engine#44054) 2023-07-27 [email protected] Roll Skia from 6571d88db5b3 to 90048a938eb5 (1 revision) (flutter/engine#44066) 2023-07-27 [email protected] Roll ANGLE from af5bf5b8245e to 8aa3ca9d177c (1 revision) (flutter/engine#44065) 2023-07-27 [email protected] Roll Dart SDK from b6747a06be06 to dcbaffbd09dd (1 revision) (flutter/engine#44064) 2023-07-27 [email protected] Roll Fuchsia Mac SDK from pgJmG2-qZVMzlMuq8... to EpwAiaHKf6M6Yejtk... (flutter/engine#44063) 2023-07-27 [email protected] Roll Skia from 26ed0d2ab04c to 6571d88db5b3 (1 revision) (flutter/engine#44062) 2023-07-27 [email protected] Roll Skia from e85c64d63787 to 26ed0d2ab04c (3 revisions) (flutter/engine#44061) 2023-07-27 [email protected] Roll Fuchsia Linux SDK from DOxjABQZ-mA_9Lllw... to FwIA6BaHtZg2mRS-0... (flutter/engine#44060) 2023-07-27 [email protected] Ignore the NOTICE.fuchsia file in the new license script (flutter/engine#44021) 2023-07-27 [email protected] Embed a license readme in every zip archive (flutter/engine#43974) 2023-07-27 [email protected] Roll Skia from 750d7f8ed4d7 to e85c64d63787 (4 revisions) (flutter/engine#44056) 2023-07-27 [email protected] Roll Dart SDK from 8961d36eaa0c to b6747a06be06 (1 revision) (flutter/engine#44053) 2023-07-26 [email protected] Roll ANGLE from 451b3c31a1fa to af5bf5b8245e (1 revision) (flutter/engine#44050) 2023-07-26 [email protected] Roll Skia from fdf224be4f98 to 750d7f8ed4d7 (3 revisions) (flutter/engine#44049) 2023-07-26 [email protected] Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048) 2023-07-26 [email protected] Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046) 2023-07-26 [email protected] Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045) 2023-07-26 [email protected] Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044) 2023-07-26 [email protected] Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043) 2023-07-26 [email protected] Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from DOxjABQZ-mA_ to FwIA6BaHtZg2 fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to EpwAiaHKf6M6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#131426) flutter/engine@9b14c38...08050cd 2023-07-27 [email protected] Roll Skia from 90048a938eb5 to 26ec2772960b (2 revisions) (flutter/engine#44070) 2023-07-27 [email protected] Roll ANGLE from 8aa3ca9d177c to d5ddb710e5bd (1 revision) (flutter/engine#44069) 2023-07-27 [email protected] [Impeller] trimmed 3 bytes off of each Glyph (flutter/engine#44054) 2023-07-27 [email protected] Roll Skia from 6571d88db5b3 to 90048a938eb5 (1 revision) (flutter/engine#44066) 2023-07-27 [email protected] Roll ANGLE from af5bf5b8245e to 8aa3ca9d177c (1 revision) (flutter/engine#44065) 2023-07-27 [email protected] Roll Dart SDK from b6747a06be06 to dcbaffbd09dd (1 revision) (flutter/engine#44064) 2023-07-27 [email protected] Roll Fuchsia Mac SDK from pgJmG2-qZVMzlMuq8... to EpwAiaHKf6M6Yejtk... (flutter/engine#44063) 2023-07-27 [email protected] Roll Skia from 26ed0d2ab04c to 6571d88db5b3 (1 revision) (flutter/engine#44062) 2023-07-27 [email protected] Roll Skia from e85c64d63787 to 26ed0d2ab04c (3 revisions) (flutter/engine#44061) 2023-07-27 [email protected] Roll Fuchsia Linux SDK from DOxjABQZ-mA_9Lllw... to FwIA6BaHtZg2mRS-0... (flutter/engine#44060) 2023-07-27 [email protected] Ignore the NOTICE.fuchsia file in the new license script (flutter/engine#44021) 2023-07-27 [email protected] Embed a license readme in every zip archive (flutter/engine#43974) 2023-07-27 [email protected] Roll Skia from 750d7f8ed4d7 to e85c64d63787 (4 revisions) (flutter/engine#44056) 2023-07-27 [email protected] Roll Dart SDK from 8961d36eaa0c to b6747a06be06 (1 revision) (flutter/engine#44053) 2023-07-26 [email protected] Roll ANGLE from 451b3c31a1fa to af5bf5b8245e (1 revision) (flutter/engine#44050) 2023-07-26 [email protected] Roll Skia from fdf224be4f98 to 750d7f8ed4d7 (3 revisions) (flutter/engine#44049) 2023-07-26 [email protected] Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048) 2023-07-26 [email protected] Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046) 2023-07-26 [email protected] Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045) 2023-07-26 [email protected] Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044) 2023-07-26 [email protected] Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043) 2023-07-26 [email protected] Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from DOxjABQZ-mA_ to FwIA6BaHtZg2 fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to EpwAiaHKf6M6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131426) flutter/engine@9b14c38...08050cd 2023-07-27 [email protected] Roll Skia from 90048a938eb5 to 26ec2772960b (2 revisions) (flutter/engine#44070) 2023-07-27 [email protected] Roll ANGLE from 8aa3ca9d177c to d5ddb710e5bd (1 revision) (flutter/engine#44069) 2023-07-27 [email protected] [Impeller] trimmed 3 bytes off of each Glyph (flutter/engine#44054) 2023-07-27 [email protected] Roll Skia from 6571d88db5b3 to 90048a938eb5 (1 revision) (flutter/engine#44066) 2023-07-27 [email protected] Roll ANGLE from af5bf5b8245e to 8aa3ca9d177c (1 revision) (flutter/engine#44065) 2023-07-27 [email protected] Roll Dart SDK from b6747a06be06 to dcbaffbd09dd (1 revision) (flutter/engine#44064) 2023-07-27 [email protected] Roll Fuchsia Mac SDK from pgJmG2-qZVMzlMuq8... to EpwAiaHKf6M6Yejtk... (flutter/engine#44063) 2023-07-27 [email protected] Roll Skia from 26ed0d2ab04c to 6571d88db5b3 (1 revision) (flutter/engine#44062) 2023-07-27 [email protected] Roll Skia from e85c64d63787 to 26ed0d2ab04c (3 revisions) (flutter/engine#44061) 2023-07-27 [email protected] Roll Fuchsia Linux SDK from DOxjABQZ-mA_9Lllw... to FwIA6BaHtZg2mRS-0... (flutter/engine#44060) 2023-07-27 [email protected] Ignore the NOTICE.fuchsia file in the new license script (flutter/engine#44021) 2023-07-27 [email protected] Embed a license readme in every zip archive (flutter/engine#43974) 2023-07-27 [email protected] Roll Skia from 750d7f8ed4d7 to e85c64d63787 (4 revisions) (flutter/engine#44056) 2023-07-27 [email protected] Roll Dart SDK from 8961d36eaa0c to b6747a06be06 (1 revision) (flutter/engine#44053) 2023-07-26 [email protected] Roll ANGLE from 451b3c31a1fa to af5bf5b8245e (1 revision) (flutter/engine#44050) 2023-07-26 [email protected] Roll Skia from fdf224be4f98 to 750d7f8ed4d7 (3 revisions) (flutter/engine#44049) 2023-07-26 [email protected] Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048) 2023-07-26 [email protected] Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046) 2023-07-26 [email protected] Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045) 2023-07-26 [email protected] Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044) 2023-07-26 [email protected] Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043) 2023-07-26 [email protected] Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from DOxjABQZ-mA_ to FwIA6BaHtZg2 fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to EpwAiaHKf6M6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
8 tasks
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 17, 2023
…#132669) flutter/engine#43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file. This is a short-term solution that will be cherry-picked for the next [3.14 beta release](#132267). Addresses #132592. The long-term solution is tracked by #132702
loic-sharma
added a commit
to loic-sharma/flutter
that referenced
this pull request
Aug 17, 2023
…flutter#132669) flutter/engine#43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file. This is a short-term solution that will be cherry-picked for the next [3.14 beta release](flutter#132267). Addresses flutter#132592. The long-term solution is tracked by flutter#132702
loic-sharma
added a commit
to loic-sharma/flutter
that referenced
this pull request
Aug 17, 2023
…flutter#132669) flutter/engine#43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file. This is a short-term solution that will be cherry-picked for the next [3.14 beta release](flutter#132267). Addresses flutter#132592. The long-term solution is tracked by flutter#132702
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
fixes flutter/flutter#130682 This patch makes all zip files created via the zip_bundle rule have an embedded LICENSE that points to a permalink to the LICENSE for that SDK commit hash. Previously we only did this for a few tools, but it was pointed out that some of the zip files we generate that are meant for consumption in the tool are otherwise missing a stand-alone license file (the tool downloads the full license file separately from the individual zips, as it would be costly to include it with each and every one).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#130682
This patch makes all zip files created via the zip_bundle rule have an embedded LICENSE that points to a permalink to the LICENSE for that SDK commit hash. Previously we only did this for a few tools, but it was pointed out that some of the zip files we generate that are meant for consumption in the tool are otherwise missing a stand-alone license file (the tool downloads the full license file separately from the individual zips, as it would be costly to include it with each and every one).