Prepare flutter engine for enabling private final field promotion. #43959

stereotype441 · 2023-07-24T16:04:53Z

Some parts of the flutter engine are built using the latest version of the Dart SDK, ignoring SDK constraints in pubspec.yaml files. Therefore, before the Dart SDK can switch on the "private field promotion" feature (dart-lang/language#2020), these parts of the flutter engine need to be modified so that they won't have any "unnecessary !" warnings after field private field promotion is enabled. This PR makes the necessary changes.

This PR doesn't introduce any functional change. In principle it might improve performance slightly (by avoiding redundant memory accesses), but in practice the difference is unlikely to rise out of the measurement noise.

Issue fixed by this PR: flutter/flutter#131198

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-07-24T16:04:57Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jonahwilliams

LGTM

goderbauer

LGTM

Hixie · 2023-07-24T18:08:19Z

lib/web_ui/lib/src/engine/semantics/semantics.dart

    // later used to fix the parent-child and sibling relationships between
    // objects.
-    for (final SemanticsNodeUpdate nodeUpdate in update._nodeUpdates!) {
+    final List<SemanticsNodeUpdate> nodeUpdates = update._nodeUpdates!;


please add an assert where the nodeUpdates variable goes out of scope that verifies that update._nodeUpdates has not changed

Hixie · 2023-07-24T18:08:40Z

test-exempt: code refactor with no semantic change

goderbauer · 2023-07-25T20:29:27Z

@jonahwilliams (engine sherif) do you know what's up with the "Linux Fuchsia FEMU" check? It keeps timing out.

jonahwilliams · 2023-07-25T20:37:39Z

I do not. I'm going to click rebase just in case, but I don't see this happening elsewhere so hopefully its just a flake...

stereotype441 · 2023-07-25T22:19:14Z

I do not. I'm going to click rebase just in case, but I don't see this happening elsewhere so hopefully its just a flake...

Thanks, Jonah! It looks like everything is working now.

…motion. (flutter/engine#43959)

…131309) flutter/engine@db711f1...7f3b0d6 2023-07-26 [email protected] Roll fallback fonts. (flutter/engine#44000) 2023-07-26 [email protected] Roll Skia from 12d41b6f66ed to 28773cec6e8d (2 revisions) (flutter/engine#44011) 2023-07-26 [email protected] Prepare flutter engine for enabling private final field promotion. (flutter/engine#43959) 2023-07-26 [email protected] Manual roll Dart SDK from 61ab5422fb7b to b1e82e2e55b2 (3 revisions) (flutter/engine#44018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#131309) flutter/engine@db711f1...7f3b0d6 2023-07-26 [email protected] Roll fallback fonts. (flutter/engine#44000) 2023-07-26 [email protected] Roll Skia from 12d41b6f66ed to 28773cec6e8d (2 revisions) (flutter/engine#44011) 2023-07-26 [email protected] Prepare flutter engine for enabling private final field promotion. (flutter/engine#43959) 2023-07-26 [email protected] Manual roll Dart SDK from 61ab5422fb7b to b1e82e2e55b2 (3 revisions) (flutter/engine#44018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#43959) Some parts of the flutter engine are built using the latest version of the Dart SDK, ignoring SDK constraints in `pubspec.yaml` files. Therefore, before the Dart SDK can switch on the "private field promotion" feature (dart-lang/language#2020), these parts of the flutter engine need to be modified so that they won't have any "unnecessary `!`" warnings after field private field promotion is enabled. This PR makes the necessary changes. This PR doesn't introduce any functional change. In principle it might improve performance slightly (by avoiding redundant memory accesses), but in practice the difference is unlikely to rise out of the measurement noise. Issue fixed by this PR: flutter/flutter#131198 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Prepare flutter engine for enabling private final field promotion.

f75c2ff

stereotype441 requested a review from goderbauer July 24, 2023 16:04

github-actions bot added the platform-web Code specifically for the web engine label Jul 24, 2023

Fix typos

62b2eb7

jonahwilliams approved these changes Jul 24, 2023

View reviewed changes

goderbauer approved these changes Jul 24, 2023

View reviewed changes

Fix prefer_final_locals lint error

db4908d

Hixie reviewed Jul 24, 2023

View reviewed changes

Address code review comment

07cc85b

Merge branch 'main' into b-2020-127

a25699d

stereotype441 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2023

auto-submit bot merged commit faf507a into flutter:main Jul 26, 2023

engine-flutter-autoroll mentioned this pull request Jul 26, 2023

Roll Flutter Engine from db711f14842b to 7f3b0d6b7250 (4 revisions) flutter/flutter#131309

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 26, 2023

faf507a5b Prepare flutter engine for enabling private final field pro…

dc4b257

…motion. (flutter/engine#43959)

stereotype441 deleted the b-2020-127 branch July 26, 2023 09:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Prepare flutter engine for enabling private final field promotion. #43959

Prepare flutter engine for enabling private final field promotion. #43959

Uh oh!

stereotype441 commented Jul 24, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jul 24, 2023

Uh oh!

jonahwilliams left a comment

Uh oh!

goderbauer left a comment

Uh oh!

Hixie Jul 24, 2023

Uh oh!

stereotype441 Jul 24, 2023

Uh oh!

Hixie commented Jul 24, 2023

Uh oh!

goderbauer commented Jul 25, 2023

Uh oh!

jonahwilliams commented Jul 25, 2023

Uh oh!

stereotype441 commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Prepare flutter engine for enabling private final field promotion. #43959

Prepare flutter engine for enabling private final field promotion. #43959

Uh oh!

Conversation

stereotype441 commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 24, 2023

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Hixie Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

stereotype441 Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

Hixie commented Jul 24, 2023

Uh oh!

goderbauer commented Jul 25, 2023

Uh oh!

jonahwilliams commented Jul 25, 2023

Uh oh!

stereotype441 commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stereotype441 commented Jul 24, 2023 •

edited

Loading