This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix clip pipeline validation failure; add dedicated clip shaders. #43946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#43905)" This reverts commit bcda9a5.
…al & Vulkan. (flutter#43781)" This reverts commit 1a8edf0.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
approved these changes
Jul 24, 2023
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
The color attachment issue would require a similar fix to the vulkan backend where the pipeline we use to create the prototype has the correct color attachment, right?
jonahwilliams
added
the
autosubmit
2 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2023
…131214) flutter/engine@2b8d83f...815b971 2023-07-24 [email protected] Fix missing dispose VirtualDisplayController (flutter/engine#43807) 2023-07-24 [email protected] [Impeller] provide cull rect to Canvas in GL/Vulakn impeller backend. (flutter/engine#43961) 2023-07-24 [email protected] [Impeller] Fix clip pipeline validation failure; add dedicated clip shaders. (flutter/engine#43946) 2023-07-24 [email protected] Roll ANGLE from e28575f66ae5 to 5e21d7f02425 (4 revisions) (flutter/engine#43964) 2023-07-24 [email protected] Roll Skia from a56bc23bfec7 to 99e8dc51ba53 (5 revisions) (flutter/engine#43963) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
Resolves flutter/flutter#131100 * Skip rect clips that we know won't further restrict the clip shape. * Don't append clips to enforce subpass bounds. We currently don't collapse passes when subpass clips are added anyhow, so just a restriction to subpass collapsing in order to keep the current behavior intact. * Small refactor to reduce confusion: Just place the subpass bounds limit into `EntityPass` itself instead of the delegate. Built on #43946 (because iOS currently fails validation without it). Gallery home screen before/after: 
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#131214) flutter/engine@2b8d83f...815b971 2023-07-24 [email protected] Fix missing dispose VirtualDisplayController (flutter/engine#43807) 2023-07-24 [email protected] [Impeller] provide cull rect to Canvas in GL/Vulakn impeller backend. (flutter/engine#43961) 2023-07-24 [email protected] [Impeller] Fix clip pipeline validation failure; add dedicated clip shaders. (flutter/engine#43946) 2023-07-24 [email protected] Roll ANGLE from e28575f66ae5 to 5e21d7f02425 (4 revisions) (flutter/engine#43964) 2023-07-24 [email protected] Roll Skia from a56bc23bfec7 to 99e8dc51ba53 (5 revisions) (flutter/engine#43963) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131214) flutter/engine@2b8d83f...815b971 2023-07-24 [email protected] Fix missing dispose VirtualDisplayController (flutter/engine#43807) 2023-07-24 [email protected] [Impeller] provide cull rect to Canvas in GL/Vulakn impeller backend. (flutter/engine#43961) 2023-07-24 [email protected] [Impeller] Fix clip pipeline validation failure; add dedicated clip shaders. (flutter/engine#43946) 2023-07-24 [email protected] Roll ANGLE from e28575f66ae5 to 5e21d7f02425 (4 revisions) (flutter/engine#43964) 2023-07-24 [email protected] Roll Skia from a56bc23bfec7 to 99e8dc51ba53 (5 revisions) (flutter/engine#43963) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out removing the color attachment is failing Metal validation on iOS due to the pipeline color attachments mismatching the framebuffer (even though it winds up rendering correctly).
So this patch replaces the mechanism with a better default config, including:
I'll take another swing at trying to get it to work if the iOS benchmarks pop back up a bit from this. For now, this fixes the validation failure and should make clips a tad faster on Vulkan and GLES.