This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor: fix typo "setup" -> "set up" #43824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jul 20, 2023
format fix fix
cyanglaz
force-pushed
the
rename_to_set_up
branch
from
7d78100 to
533f776
Compare
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 21, 2023
…ions) (#131092) Manual roll requested by [email protected] flutter/engine@acb5d06...2d8cff4 2023-07-21 [email protected] Refactor: fix typo "setup" -> "set up" (flutter/engine#43824) 2023-07-21 [email protected] [engine] disable picture complexity raster caching (flutter/engine#43897) 2023-07-21 [email protected] Roll Skia from e3d13d1b1c42 to 1f84e9d51bba (1 revision) (flutter/engine#43896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…ions) (flutter#131092) Manual roll requested by [email protected] flutter/engine@acb5d06...2d8cff4 2023-07-21 [email protected] Refactor: fix typo "setup" -> "set up" (flutter/engine#43824) 2023-07-21 [email protected] [engine] disable picture complexity raster caching (flutter/engine#43897) 2023-07-21 [email protected] Roll Skia from e3d13d1b1c42 to 1f84e9d51bba (1 revision) (flutter/engine#43896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…ions) (flutter#131092) Manual roll requested by [email protected] flutter/engine@acb5d06...2d8cff4 2023-07-21 [email protected] Refactor: fix typo "setup" -> "set up" (flutter/engine#43824) 2023-07-21 [email protected] [engine] disable picture complexity raster caching (flutter/engine#43897) 2023-07-21 [email protected] Roll Skia from e3d13d1b1c42 to 1f84e9d51bba (1 revision) (flutter/engine#43896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places in the engine using the word "setup" incorrectly. I have changed them to "set up"
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.