Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

These builds have had engine v2 variants running for nearly a quarter or more in most cases, and they are now not serving much of a purpose. Additionally, during MTV peak hours, queue times and therefore overall cycle times are getting too long, and we should be freeing up these resources.

Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit f189d8f into flutter:main Jul 18, 2023
@zanderso zanderso deleted the remove-some-engine-v1 branch July 18, 2023 22:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2023
…130843)

flutter/engine@adf6142...b3bfc74

2023-07-18 [email protected] Increase engine v2 orchestrator timeouts (flutter/engine#43788)
2023-07-18 [email protected] Roll Skia from dcc56df202cc to 280fb8391187 (1 revision) (flutter/engine#43793)
2023-07-18 [email protected] Remove obsolete legacy engine builds from staging (flutter/engine#43790)
2023-07-18 [email protected] Roll ANGLE from 52fe3116ead9 to 6eea5ff4db82 (1 revision) (flutter/engine#43789)
2023-07-18 [email protected] [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785)
2023-07-18 [email protected] Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784)
2023-07-18 [email protected] Roll Fuchsia Linux SDK from ixKM7wyMrqmPDaQ11... to ZABO4Om1vToxhI394... (flutter/engine#43782)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ixKM7wyMrqmP to ZABO4Om1vTox

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit to harryterkelsen/engine that referenced this pull request Jul 20, 2023
These builds have had engine v2 variants running for nearly a quarter or
more in most cases, and they are now not serving much of a purpose.
Additionally, during MTV peak hours, queue times and therefore overall
cycle times are getting too long, and we should be freeing up these
resources.
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
…lutter#130843)

flutter/engine@adf6142...b3bfc74

2023-07-18 [email protected] Increase engine v2 orchestrator timeouts (flutter/engine#43788)
2023-07-18 [email protected] Roll Skia from dcc56df202cc to 280fb8391187 (1 revision) (flutter/engine#43793)
2023-07-18 [email protected] Remove obsolete legacy engine builds from staging (flutter/engine#43790)
2023-07-18 [email protected] Roll ANGLE from 52fe3116ead9 to 6eea5ff4db82 (1 revision) (flutter/engine#43789)
2023-07-18 [email protected] [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785)
2023-07-18 [email protected] Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784)
2023-07-18 [email protected] Roll Fuchsia Linux SDK from ixKM7wyMrqmPDaQ11... to ZABO4Om1vToxhI394... (flutter/engine#43782)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ixKM7wyMrqmP to ZABO4Om1vTox

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants