Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Jul 18, 2023

This PR increases orchestrator timeouts to avoid the case where subjobs that are making progress after a long queue time may be needlessly cancelled if the orchestrator runs over a too-small timeout.

@zanderso zanderso requested a review from bdero July 18, 2023 21:22
@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@zanderso zanderso force-pushed the increase-timeouts branch from 4364f3b to adcc3bd Compare July 18, 2023 22:24
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 18, 2023

auto label is removed for flutter/engine, pr: 43788, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit auto-submit bot merged commit b3bfc74 into flutter:main Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2023
…130843)

flutter/engine@adf6142...b3bfc74

2023-07-18 [email protected] Increase engine v2 orchestrator timeouts (flutter/engine#43788)
2023-07-18 [email protected] Roll Skia from dcc56df202cc to 280fb8391187 (1 revision) (flutter/engine#43793)
2023-07-18 [email protected] Remove obsolete legacy engine builds from staging (flutter/engine#43790)
2023-07-18 [email protected] Roll ANGLE from 52fe3116ead9 to 6eea5ff4db82 (1 revision) (flutter/engine#43789)
2023-07-18 [email protected] [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785)
2023-07-18 [email protected] Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784)
2023-07-18 [email protected] Roll Fuchsia Linux SDK from ixKM7wyMrqmPDaQ11... to ZABO4Om1vToxhI394... (flutter/engine#43782)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ixKM7wyMrqmP to ZABO4Om1vTox

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@zanderso zanderso deleted the increase-timeouts branch July 19, 2023 01:44
harryterkelsen pushed a commit to harryterkelsen/engine that referenced this pull request Jul 20, 2023
This PR increases orchestrator timeouts to avoid the case where subjobs that are making progress after a long queue time may be needlessly cancelled if the orchestrator runs over a too-small timeout.
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
…lutter#130843)

flutter/engine@adf6142...b3bfc74

2023-07-18 [email protected] Increase engine v2 orchestrator timeouts (flutter/engine#43788)
2023-07-18 [email protected] Roll Skia from dcc56df202cc to 280fb8391187 (1 revision) (flutter/engine#43793)
2023-07-18 [email protected] Remove obsolete legacy engine builds from staging (flutter/engine#43790)
2023-07-18 [email protected] Roll ANGLE from 52fe3116ead9 to 6eea5ff4db82 (1 revision) (flutter/engine#43789)
2023-07-18 [email protected] [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785)
2023-07-18 [email protected] Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784)
2023-07-18 [email protected] Roll Fuchsia Linux SDK from ixKM7wyMrqmPDaQ11... to ZABO4Om1vToxhI394... (flutter/engine#43782)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ixKM7wyMrqmP to ZABO4Om1vTox

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants