This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Apply the offset to the child bounds of an ImageFilterLayer with no filter #43783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't think this fixes all of the issue since there is still the case that we null the filter if either sigma is 0 rather than if both are 0. So, this is a good fix for "part of" flutter/flutter#130318? |
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 19, 2023
…130903) flutter/engine@9645d8e...4b274b5 2023-07-19 [email protected] Roll Skia from 16475d7aa315 to 4728980564b1 (1 revision) (flutter/engine#43815) 2023-07-19 [email protected] Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783) 2023-07-19 [email protected] Roll Skia from 1f175b7a2155 to 16475d7aa315 (1 revision) (flutter/engine#43812) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130903) flutter/engine@9645d8e...4b274b5 2023-07-19 [email protected] Roll Skia from 16475d7aa315 to 4728980564b1 (1 revision) (flutter/engine#43815) 2023-07-19 [email protected] Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783) 2023-07-19 [email protected] Roll Skia from 1f175b7a2155 to 16475d7aa315 (1 revision) (flutter/engine#43812) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#130318