This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. #43781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 19, 2023
…130920) flutter/engine@4b274b5...2fab8ab 2023-07-19 [email protected] Roll Skia from 4728980564b1 to a352521a3a7c (3 revisions) (flutter/engine#43816) 2023-07-19 [email protected] [Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. (flutter/engine#43781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
yaakovschectman
pushed a commit
to yaakovschectman/flutter-engine
that referenced
this pull request
Jul 19, 2023
…kan. (flutter#43781) Remove the color attachment completely in Metal and Vulkan clips. When the color write mask is set to all false, Metal is smart about not executing the fragment shader at all, but some Vulkan and GL drivers may not be. GL requires binding shader objects to draw, and so a cap check is needed here. In the future, we could add minimal no-op shaders to use with the GL clip pipeline to shave off a few flops on drivers that aren't smart about the color write mask.
Member
|
There was an improvement to worst frame rasterizer time on iOS on this change: https://flutter-flutter-perf.skia.org/e/?begin=1689771623&end=1689807235&keys=Xb32df78351d0d4eca428a1f6cf024fde&num_commits=50&request_type=1&xbaroffset=35851 |
Member
|
Looks good. It seems to be stable too. |
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
…kan. (flutter#43781) Remove the color attachment completely in Metal and Vulkan clips. When the color write mask is set to all false, Metal is smart about not executing the fragment shader at all, but some Vulkan and GL drivers may not be. GL requires binding shader objects to draw, and so a cap check is needed here. In the future, we could add minimal no-op shaders to use with the GL clip pipeline to shave off a few flops on drivers that aren't smart about the color write mask.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Jul 24, 2023
…al & Vulkan. (flutter#43781)" This reverts commit 1a8edf0.
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130920) flutter/engine@4b274b5...2fab8ab 2023-07-19 [email protected] Roll Skia from 4728980564b1 to a352521a3a7c (3 revisions) (flutter/engine#43816) 2023-07-19 [email protected] [Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. (flutter/engine#43781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the color attachment completely in Metal and Vulkan clips.
When the color write mask is set to all false, Metal is smart about not executing the fragment shader at all, but some Vulkan and GL drivers may not be. GL requires binding shader objects to draw, and so a cap check is needed here.
In the future, we could add minimal no-op shaders to use with the GL clip pipeline to shave off a few flops on drivers that aren't smart about the color write mask.