Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@CaseyHillers
Copy link
Contributor

This is blocking the beta release as the builder is running unnecessarily.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

Copy link
Contributor

@drewroengoogle drewroengoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit auto-submit bot merged commit 3f9634e into flutter:main Jul 18, 2023
auto-submit bot pushed a commit that referenced this pull request Jul 18, 2023
CP of #43771

Skip windows arm on release branches. This broke during the migration to the release builders.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 18, 2023
…130820)

flutter/engine@45851af...71bbece

2023-07-18 [email protected] [web] sync => isSync , scuba => golden (flutter/engine#43699)
2023-07-18 [email protected] Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777)
2023-07-18 [email protected] Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776)
2023-07-18 [email protected] Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774)
2023-07-18 [email protected] [ci.yaml] Skip windows arm on releases (flutter/engine#43771)
2023-07-18 [email protected] Check FlutterAppDelegate selector support before calling (flutter/engine#43425)
2023-07-18 [email protected] Roll Fuchsia Mac SDK from _CIP-1iUTmGCbCDZ5... to SCshjyIlymHWD9W4D... (flutter/engine#43773)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from _CIP-1iUTmGC to SCshjyIlymHW

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit to harryterkelsen/engine that referenced this pull request Jul 20, 2023
This is blocking the beta release as the builder is running unnecessarily.
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
…lutter#130820)

flutter/engine@45851af...71bbece

2023-07-18 [email protected] [web] sync => isSync , scuba => golden (flutter/engine#43699)
2023-07-18 [email protected] Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777)
2023-07-18 [email protected] Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776)
2023-07-18 [email protected] Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774)
2023-07-18 [email protected] [ci.yaml] Skip windows arm on releases (flutter/engine#43771)
2023-07-18 [email protected] Check FlutterAppDelegate selector support before calling (flutter/engine#43425)
2023-07-18 [email protected] Roll Fuchsia Mac SDK from _CIP-1iUTmGCbCDZ5... to SCshjyIlymHWD9W4D... (flutter/engine#43773)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from _CIP-1iUTmGC to SCshjyIlymHW

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants