This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Move glyph atlas state from context into lazy glyph atlas. #43748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
Contributor
Author
|
Friendly ping @dnfield |
chinmaygarde
approved these changes
Jul 27, 2023
dnfield
approved these changes
Jul 27, 2023
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 27, 2023
…131439) flutter/engine@9a935ec...284771d 2023-07-27 [email protected] Revert "[engine] disable picture complexity raster caching" (flutter/engine#44026) 2023-07-27 [email protected] [Impeller] Move glyph atlas state from context into lazy glyph atlas. (flutter/engine#43748) 2023-07-27 [email protected] Hide some log lines from release builds (flutter/engine#44073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#131439) flutter/engine@9a935ec...284771d 2023-07-27 [email protected] Revert "[engine] disable picture complexity raster caching" (flutter/engine#44026) 2023-07-27 [email protected] [Impeller] Move glyph atlas state from context into lazy glyph atlas. (flutter/engine#43748) 2023-07-27 [email protected] Hide some log lines from release builds (flutter/engine#44073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131439) flutter/engine@9a935ec...284771d 2023-07-27 [email protected] Revert "[engine] disable picture complexity raster caching" (flutter/engine#44026) 2023-07-27 [email protected] [Impeller] Move glyph atlas state from context into lazy glyph atlas. (flutter/engine#43748) 2023-07-27 [email protected] Hide some log lines from release builds (flutter/engine#44073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…flutter#43748) No impact on behavior. Rather that separately cache the lazy glyph atlas and the underlying state (bitmap, atlas, texture), move the state into the lazy glyph atlas. To do make this behave correctly, we need to "reset" the lazy glyph atlas instead of deleting it on each frame. Reseting it clears out the text runs and cached atlas, which has the same impact as deleting it in the previous behavior. This refactor is required in order to move to platform specific glyph atlases, to solve issues such as flutter/flutter#126104
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No impact on behavior. Rather that separately cache the lazy glyph atlas and the underlying state (bitmap, atlas, texture), move the state into the lazy glyph atlas. To do make this behave correctly, we need to "reset" the lazy glyph atlas instead of deleting it on each frame. Reseting it clears out the text runs and cached atlas, which has the same impact as deleting it in the previous behavior.
This refactor is required in order to move to platform specific glyph atlases, to solve issues such as flutter/flutter#126104