This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix drawVertices documentation #43747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
approved these changes
Jul 17, 2023
Contributor
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
LGTM - just to be sure, did we at last get the dst vs src behaviors correct?
Contributor
Author
|
Yup, the rest of the prose is correct (both in identifying which is the src vs. dst, and which blend mode selects each color). |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Contributor
|
The Skia gold changes must be flakes. Try rebasing and it should succeed second time... |
brianosman
force-pushed
the
drawvertices-docs
branch
from
2b0afb6 to
1fb11f4
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 18, 2023
…130763) flutter/engine@09689d3...3cceb70 2023-07-17 [email protected] Fix drawVertices documentation (flutter/engine#43747) 2023-07-17 [email protected] Revert "Roll Clang from 6d667d4b261e to ebd0b8a0472b" (flutter/engine#43749) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
Update the blend mode section of the documentation to specify the correct blend modes. Fixes flutter/flutter#130747
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130763) flutter/engine@09689d3...3cceb70 2023-07-17 [email protected] Fix drawVertices documentation (flutter/engine#43747) 2023-07-17 [email protected] Revert "Roll Clang from 6d667d4b261e to ebd0b8a0472b" (flutter/engine#43749) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the blend mode section of the documentation to specify the correct blend modes.
Fixes flutter/flutter#130747