This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Correct coverage hint usage in PipelineBlend #43708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
commented
Jul 14, 2023
|
|
||
| if (coverage_hint.has_value()) { | ||
| auto maybe_subpass_coverage = | ||
| subpass_coverage.Intersection(*coverage_hint); |
Member
Author
There was a problem hiding this comment.
This was the bug: Grabbing the minimum size isn't enough -- we need to intersect the rectangles and then render the blended result to the minimal subpass texture. That means we need to offset both the geometry drawn to the subpass as well as the returned Entity's transform to account for this.
bdero
force-pushed
the
bdero/fix-blend-coverage-hint
branch
from
76e9722 to
7b1f351
Compare
Member
|
Does this also apply to the use of |
Member
Author
|
Yeah, thanks. Pushed a fix for the advanced blend. |
chinmaygarde
approved these changes
Jul 17, 2023
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jason-simmons
approved these changes
Jul 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2023
…130741) flutter/engine@aa3239c...ddbe23b 2023-07-17 [email protected] Roll Skia from b25cd035db06 to f0e1963324eb (2 revisions) (flutter/engine#43741) 2023-07-17 [email protected] Roll Skia from dc93f341ec38 to b25cd035db06 (2 revisions) (flutter/engine#43740) 2023-07-17 [email protected] [Impeller] Correct coverage hint usage in PipelineBlend (flutter/engine#43708) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
Resolves flutter/flutter#130411. The remaining difference in appearance is due to flutter/flutter#127770 -- Impeller's blurs skew too large. Before:  After: 
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130741) flutter/engine@aa3239c...ddbe23b 2023-07-17 [email protected] Roll Skia from b25cd035db06 to f0e1963324eb (2 revisions) (flutter/engine#43741) 2023-07-17 [email protected] Roll Skia from dc93f341ec38 to b25cd035db06 (2 revisions) (flutter/engine#43740) 2023-07-17 [email protected] [Impeller] Correct coverage hint usage in PipelineBlend (flutter/engine#43708) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#130411.
The remaining difference in appearance is due to flutter/flutter#127770 -- Impeller's blurs skew too large.
Before:
After: