This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix DisplayListMatrixClipTracker handling of diff clips #43664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopp
approved these changes
Jul 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 14, 2023
…130601) flutter/engine@c8dbd8a...63e9cbe 2023-07-14 [email protected] Add missing Skia #includes (flutter/engine#43680) 2023-07-14 [email protected] Roll Skia from de6099518f90 to c14fda1cb615 (1 revision) (flutter/engine#43689) 2023-07-14 [email protected] Fix DisplayListMatrixClipTracker handling of diff clips (flutter/engine#43664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
…41463) (#43698) Fixes flutter/flutter#129862 This reverts commit fc9fc93. These changes were exposing an underlying bug in the DisplayListMatrixClipTracker that has now been fixed independently (#43664). There are no changes to the commit being relanded here, it has been tested on the Wondrous app which demonstrated the regression before the NOP culling feature was reverted and it now works fine due to the fix of the underlying cause.
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
Fixes root cause for flutter/flutter#129816 Logic for reducing the cull_rect for a diff clip had a number of errors. The new test should cover all cases.
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
…lutter#41463) (flutter#43698) Fixes flutter/flutter#129862 This reverts commit fc9fc93. These changes were exposing an underlying bug in the DisplayListMatrixClipTracker that has now been fixed independently (flutter#43664). There are no changes to the commit being relanded here, it has been tested on the Wondrous app which demonstrated the regression before the NOP culling feature was reverted and it now works fine due to the fix of the underlying cause.
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130601) flutter/engine@c8dbd8a...63e9cbe 2023-07-14 [email protected] Add missing Skia #includes (flutter/engine#43680) 2023-07-14 [email protected] Roll Skia from de6099518f90 to c14fda1cb615 (1 revision) (flutter/engine#43689) 2023-07-14 [email protected] Fix DisplayListMatrixClipTracker handling of diff clips (flutter/engine#43664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes root cause for flutter/flutter#129816
Logic for reducing the cull_rect for a diff clip had a number of errors. The new test should cover all cases.