This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable WebP #4359
Merged
Enable WebP #4359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
suggested changes
Nov 14, 2017
DEPS
Outdated
| 'fuchsia_git': 'https://fuchsia.googlesource.com', | ||
| 'skia_git': 'https://skia.googlesource.com', | ||
| 'github_git': 'https://github.com', | ||
| 'libwebp_git': 'https://chromium.googlesource.com/webm', |
Member
There was a problem hiding this comment.
https://chromium.googlesource.com is already present in the var above. Please just use that var directly below.
DEPS
Outdated
| Var('skia_git') + '/third_party/libjpeg-turbo.git' + '@' + 'debddedc75850bcdeb8a57258572f48b802a4bb3', | ||
|
|
||
| 'src/third_party/libwebp': | ||
| Var('libwebp_git') + '/libwebp.git' + '@' + '0.6.0', |
Member
There was a problem hiding this comment.
Var('chromium_git') + '/webm/libwebp.git' + '@' + '0.6.0',
lib/ui/painting/codec.cc
Outdated
| if (skCodec->getFrameCount() > 1) { | ||
| if (skCodec->getFrameCount() > 1 | ||
| // Temporarily disable WebP animations due to: | ||
| // https://github.com/flutter/flutter/issues/13017 |
Member
There was a problem hiding this comment.
Please add a // TODO(amirh) here.
Contributor
Author
There was a problem hiding this comment.
I completely removed this as the Skia fix landed
tools/gn
Outdated
| gn_args['skia_use_dng_sdk'] = False # RAW image handling. | ||
| gn_args['skia_use_sfntly'] = False # PDF handling. | ||
| gn_args['skia_use_libwebp'] = False # Needs third_party/libwebp. | ||
| gn_args['skia_use_libwebp'] = True # WebP codec. |
Member
There was a problem hiding this comment.
I dont think you need this anymore.
chinmaygarde
approved these changes
Nov 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#9857