This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Release the mutex in the CanCreateConcurrentMessageLoop test before waking the latch #43574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking the latch If the wake happens while thread_ids_mutex is still held, then the test function may exit and destroy thread_ids_mutex before the pool thread task releases it. Fixes flutter/flutter#130344
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2023
…t before waking the latch (flutter/engine#43574)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 12, 2023
…130369) flutter/engine@875d87e...d00590f 2023-07-11 [email protected] Release the mutex in the CanCreateConcurrentMessageLoop test before waking the latch (flutter/engine#43574) 2023-07-11 [email protected] Roll Skia from 2998197ce4ca to c769464a8b79 (2 revisions) (flutter/engine#43577) 2023-07-11 [email protected] Run linux_unopt on a machine with more cores (flutter/engine#43473) 2023-07-11 [email protected] Roll Skia from d2051446ee6b to 2998197ce4ca (1 revision) (flutter/engine#43572) 2023-07-11 [email protected] Roll Dart SDK from 8b1c04086525 to 551915bf6ebe (1 revision) (flutter/engine#43571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 13, 2023
…lutter#130369) flutter/engine@875d87e...d00590f 2023-07-11 [email protected] Release the mutex in the CanCreateConcurrentMessageLoop test before waking the latch (flutter/engine#43574) 2023-07-11 [email protected] Roll Skia from 2998197ce4ca to c769464a8b79 (2 revisions) (flutter/engine#43577) 2023-07-11 [email protected] Run linux_unopt on a machine with more cores (flutter/engine#43473) 2023-07-11 [email protected] Roll Skia from d2051446ee6b to 2998197ce4ca (1 revision) (flutter/engine#43572) 2023-07-11 [email protected] Roll Dart SDK from 8b1c04086525 to 551915bf6ebe (1 revision) (flutter/engine#43571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
…aking the latch (flutter#43574) If the wake happens while thread_ids_mutex is still held, then the test function may exit and destroy thread_ids_mutex before the pool thread task releases it. Fixes flutter/flutter#130344
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the wake happens while thread_ids_mutex is still held, then the test function may exit and destroy thread_ids_mutex before the pool thread task releases it.
Fixes flutter/flutter#130344