This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia][cml] Mark Tracing as Optional #43567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
First time having to PR to flutter, let me know if I missed anything in the contributing guidelines. Internal staged presubmits: cl/547246543 |
Tracing is an optional component that is only included in eng builds, so the usage should be marked optional.
chinmaygarde
approved these changes
Jul 11, 2023
Contributor
Author
|
@chinmaygarde I don't have merge access, so I'll need someone to merge this for me once the tree is no longer broken. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 11, 2023
…130359) flutter/engine@e2df016...875d87e 2023-07-11 [email protected] [Impeller] Fix WRITE_AFTER_WRITE hazard in ColorWheel/Vulkan. (flutter/engine#43570) 2023-07-11 [email protected] Roll Skia from 47a37395ee40 to d2051446ee6b (4 revisions) (flutter/engine#43569) 2023-07-11 [email protected] [fuchsia][cml] Mark Tracing as Optional (flutter/engine#43567) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arbreng
approved these changes
Jul 13, 2023
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Tracing is an optional component that is only included in eng builds, so the usage should be marked optional. Bug: fxbug.dev/112433
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing is an optional component that is only included in eng builds, so the usage should be marked optional.
Bug: fxbug.dev/112433