This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Handle nested display list clips in Impeller dispatcher (#43442) #43469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flutter/flutter#130084 If a display list is drawn into another display list and the child display list establishes a small clip, subsequent drawing operations are discarded when really they should not be. The test is expected to render both a blue and a red square; before the fix it renders only the blue square since the red square is incorrectly clipped out. See also dnfield/flutter_svg#938
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
Contributor
|
FYI presubmit is failing on |
zanderso
approved these changes
Jul 7, 2023
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
lgtm after fixing the merge issue.
Contributor
Author
|
An intermediate commit made the arguments optional, providing the correct values for them now in the test. |
CaseyHillers
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 43469, due to - The status or check suite Windows Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
Author
|
missed a namespace qualifier... |
CaseyHillers
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
) Cherry pick the same pick as for 3.10 (#43469 and flutter/flutter#130149). Fixes flutter/flutter#130084 If a display list is drawn into another display list and the child display list establishes a small clip, subsequent drawing operations are discarded when really they should not be. The test is expected to render both a blue and a red square; before the fix it renders only the blue square since the red square is incorrectly clipped out. See also dnfield/flutter_svg#938
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP issue: flutter/flutter#130149
Fixes flutter/flutter#130084
If a display list is drawn into another display list and the child display list establishes a small clip, subsequent drawing operations are discarded when really they should not be.
The test is expected to render both a blue and a red square; before the fix it renders only the blue square since the red square is incorrectly clipped out.
See also dnfield/flutter_svg#938