This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Fix tests; remove fuchsia dart SDK deps #43461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
force-pushed
the
fix-test
branch
3 times, most recently
from
8ab3de7 to
64ffbb3
Compare
miguelfrde
reviewed
Jul 7, 2023
miguelfrde
reviewed
Jul 7, 2023
miguelfrde
reviewed
Jul 7, 2023
shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_echo_server/BUILD.gn
Outdated
Show resolved
Hide resolved
arbreng
force-pushed
the
fix-test
branch
2 times, most recently
from
7ac6705 to
dbde2d8
Compare
Dart is being removed from the Fuchsia SDK, so remove references to it here. Also remove references to workstation_eng and replace with terminal. workstation_eng is no longer a thing.
chinmaygarde
approved these changes
Jul 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 8, 2023
…130189) flutter/engine@40a8732...13d9d84 2023-07-07 [email protected] [fuchsia] Fix tests; remove fuchsia dart SDK deps (flutter/engine#43461) 2023-07-07 [email protected] Roll Fuchsia Mac SDK from MPy31yjgPV-d_YJq0... to 8YPOimmJgaAd5SlAT... (flutter/engine#43481) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from MPy31yjgPV-d to 8YPOimmJgaAd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Dart is being removed from the Fuchsia SDK, so remove references to it here. Also remove references to workstation_eng and replace with terminal. workstation_eng is no longer a thing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart is being removed from the Fuchsia SDK, so remove references to it here.
Also remove references to workstation_eng and replace with terminal. workstation_eng is no longer a thing.