This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Account for updated Impeller label. #43450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The label was updated in flutter.dev/go/triage-2023-rfc
Member
Author
|
I think this is how it works? Not sure how to test it. Adding the label without quotes was making the YAML become invalid. |
Contributor
|
https://github.com/flutter/flutter/blob/master/.github/labeler.yml uses single quotes, but I don't know if it matters. |
Hixie
approved these changes
Jul 6, 2023
Contributor
Hixie
left a comment
Hixie
left a comment
There was a problem hiding this comment.
Thanks for fixing my mess!
chinmaygarde
added
the
autosubmit
Member
Author
|
I think this one was an own goal. I was using the same labels across both the framework and engine repos so I could show PRs and issues on the same dashboard. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 7, 2023
…130107) flutter/engine@48bf7ac...491f317 2023-07-06 [email protected] Account for updated Impeller label. (flutter/engine#43450) 2023-07-06 [email protected] [Impeller] Fix DrawPicture. (flutter/engine#43446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
The label was updated per flutter.dev/go/triage-2023-rfc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label was updated per flutter.dev/go/triage-2023-rfc