This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Check FlutterAppDelegate selector support before calling #43425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
check_delegate_selectors
branch
from
5c44501 to
af32633
Compare
Contributor
Author
|
@cbracken How would I set the delegate to a non- |
2 tasks
Member
|
You should be able to just create a class that extends |
cbracken
reviewed
Jul 11, 2023
cbracken
reviewed
Jul 11, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Overall lgtm - just the test to do.
gspencergoog
force-pushed
the
check_delegate_selectors
branch
from
85a5c53 to
5fba395
Compare
gspencergoog
force-pushed
the
check_delegate_selectors
branch
from
5fba395 to
25609e0
Compare
gspencergoog
commented
Jul 14, 2023
Contributor
Author
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Okay, this is ready for a "real" review. I added a test.
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 18, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 18, 2023
…130820) flutter/engine@45851af...71bbece 2023-07-18 [email protected] [web] sync => isSync , scuba => golden (flutter/engine#43699) 2023-07-18 [email protected] Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777) 2023-07-18 [email protected] Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776) 2023-07-18 [email protected] Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774) 2023-07-18 [email protected] [ci.yaml] Skip windows arm on releases (flutter/engine#43771) 2023-07-18 [email protected] Check FlutterAppDelegate selector support before calling (flutter/engine#43425) 2023-07-18 [email protected] Roll Fuchsia Mac SDK from _CIP-1iUTmGCbCDZ5... to SCshjyIlymHWD9W4D... (flutter/engine#43773) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from _CIP-1iUTmGC to SCshjyIlymHW If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
## Description This adds checks for the app delegate to make sure that it supports the Flutter-specific selectors before calling them, so that a non `FlutterAppDelegate` can be used for the `NSApplicationDelegate` on `NSApp`. ## Related Issues - flutter/flutter#124829 - flutter/flutter#127476 ## Tests - Added a test to make sure things don't crash if the app delegate isn't a `FlutterAppDelegate`.
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130820) flutter/engine@45851af...71bbece 2023-07-18 [email protected] [web] sync => isSync , scuba => golden (flutter/engine#43699) 2023-07-18 [email protected] Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777) 2023-07-18 [email protected] Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776) 2023-07-18 [email protected] Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774) 2023-07-18 [email protected] [ci.yaml] Skip windows arm on releases (flutter/engine#43771) 2023-07-18 [email protected] Check FlutterAppDelegate selector support before calling (flutter/engine#43425) 2023-07-18 [email protected] Roll Fuchsia Mac SDK from _CIP-1iUTmGCbCDZ5... to SCshjyIlymHWD9W4D... (flutter/engine#43773) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from _CIP-1iUTmGC to SCshjyIlymHW If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds checks for the app delegate to make sure that it supports the Flutter-specific selectors before calling them, so that a non
FlutterAppDelegatecan be used for theNSApplicationDelegateonNSApp.Related Issues
Tests
FlutterAppDelegate.