This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix advanced CPU blend modes #43294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/advanced-cpu-blends
branch
from
0620264 to
2744527
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bdero
added
autosubmit
bdero
force-pushed
the
bdero/advanced-cpu-blends
branch
from
2744527 to
dd53557
Compare
Member
Author
|
I refactored this to replace the internal blend applicator lambdas with inlined functions because they were permanently capturing values between invocations of |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 29, 2023
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 29, 2023
…129750) flutter/engine@4e49b9d...d5c25ea 2023-06-29 [email protected] [Impeller] Add a missing method to the Context mock (flutter/engine#43326) 2023-06-29 [email protected] [Impeller] Collapse DrawRects into clear colors optimization (flutter/engine#43168) 2023-06-29 [email protected] [Impeller] Add trace events to Vulkan texture and buffer lifecycle events. (flutter/engine#43321) 2023-06-29 [email protected] Roll Dart SDK from 5a59cd06e49d to a7151d73b88d (2 revisions) (flutter/engine#43318) 2023-06-28 [email protected] [Impeller] Fix advanced CPU blend modes (flutter/engine#43294) 2023-06-28 [email protected] Roll Fuchsia Linux SDK from 10hNrVMjnCypybnz2... to fxCNy4QivAngZXkvM... (flutter/engine#43314) 2023-06-28 [email protected] Roll Skia from 0b4f472a8c44 to 26fa4b343fd3 (2 revisions) (flutter/engine#43306) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 10hNrVMjnCyp to fxCNy4QivAng If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Resolves flutter/flutter#128606. All CPU blends now match the behavior of Impeller's GPU blends, which (after flutter#43283) closely matches Skia's blends! Now we can finally use these. https://github.com/flutter/engine/assets/919017/f9dc7323-fd14-4cdc-ba8b-930622be4206
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#128606.
All CPU blends now match the behavior of Impeller's GPU blends, which (after #43283) closely matches Skia's blends! Now we can finally use these.
Screen.Recording.2023-06-27.at.6.15.14.PM.mov